Date: Tue, 23 Mar 2010 09:34:39 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: Daniel Braniss <danny@cs.huji.ac.il> Cc: bug-followup@FreeBSD.org, freebsd-fs@FreeBSD.org, Kai Kockro <kkockro@web.de> Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs Message-ID: <Pine.GSO.4.63.1003230930490.26737@muncher.cs.uoguelph.ca> In-Reply-To: <E1NtzZK-000O4D-Bh@kabab.cs.huji.ac.il> References: <201003171120.o2HBK3CV082081@freefall.freebsd.org> <20100317113953.GA14582@icarus.home.lan> <Pine.GSO.4.63.1003171844120.20254@muncher.cs.uoguelph.ca> <86tys9eqo6.fsf@kopusha.onet> <Pine.GSO.4.63.1003212018180.28991@muncher.cs.uoguelph.ca> <E1NtfW6-0008E7-9q@kabab.cs.huji.ac.il> <Pine.GSO.4.63.1003220949490.11799@muncher.cs.uoguelph.ca> <E1NtjBJ-000AyL-B5@kabab.cs.huji.ac.il> <Pine.GSO.4.63.1003222039480.27739@muncher.cs.uoguelph.ca> <E1NtzZK-000O4D-Bh@kabab.cs.huji.ac.il>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 23 Mar 2010, Daniel Braniss wrote: >> I only have a FreeBSD client at this point, and it doesn't cause the >> leak for nfsv3,udp for me here. > my client is also FreeBSD 8.0, strange > I was already using the patch below when I tested and couldn't see it, so I guess it now appears that the patch works. >> >> Doug Rabson pointed out that there would be a leak for the "default:" >> case too, although didn't know if that would occur in practice. > it does! :-) > >> >> So, maybe you could test this variant of the patch (just in case that >> was the slow leak...): >> --- rpc/svc.c.sav 2010-03-21 18:46:20.000000000 -0400 >> +++ rpc/svc.c 2010-03-22 19:00:17.000000000 -0400 >> @@ -819,9 +819,11 @@ >> free(r->rq_addr, M_SONAME); >> r->rq_addr = NULL; >> } >> + m_freem(args); >> goto call_done; >> >> default: >> + m_freem(args); >> goto call_done; >> } >> } > that plugged it! > see > ftp://ftp.cs.huji.ac.il/users/danny/freebsd/mbuf-leak/store-02+++.ps Good work with the testing. I'll get it committed and put it up on the nfs patches page I have under http://people.freebsd.org/~rmacklem > thanks to you for taking time off of your retirement :-) > I plan on doing quite a bit of FreeBSD/NFS stuff during it, rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.63.1003230930490.26737>