Date: Mon, 29 Oct 2001 00:11:24 -0500 (EST) From: "Andrew R. Reiter" <arr@watson.org> To: Josef Karthauser <joe@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <Pine.NEB.3.96L.1011029000720.32447A-100000@fledge.watson.org> In-Reply-To: <200110290441.f9T4fSY68423@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry to reply to ipfw.c commits this way, but while there have been style fixes, I don't think all have been fixed. For example, in show_ipfw(), there is char timestr[30]; which is found in the middle of an if block. IIRC, isn't this a style problem as well? Also, I would imagine that it's just poor design to have to declare variables in the middle of a block, whether it be an if-block, for-block, etc.. Cheers, Andrew ps. sorry again to reply to it this way, accidently deleted commit mail. On Sun, 28 Oct 2001, Josef Karthauser wrote: :joe 2001/10/28 20:41:28 PST : : Modified files: : sys/netinet ip_fw.h : Log: : Clean up the style of this header file. : : Revision Changes Path : 1.60 +190 -186 src/sys/netinet/ip_fw.h : :To Unsubscribe: send mail to majordomo@FreeBSD.org :with "unsubscribe cvs-all" in the body of the message : *-------------................................................. | Andrew R. Reiter | arr@fledge.watson.org | "It requires a very unusual mind | to undertake the analysis of the obvious" -- A.N. Whitehead To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1011029000720.32447A-100000>