Date: Sun, 25 Nov 2001 17:55:42 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: Ian Dowse <iedowse@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/tail forward.c Message-ID: <Pine.NEB.3.96L.1011125175449.74761B-100000@fledge.watson.org> In-Reply-To: <20011125144540.A93369@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sun, Nov 25, 2001 at 10:03:28AM -0800, Ian Dowse wrote: > > iedowse 2001/11/25 10:03:28 PST > > > > Modified files: > > usr.bin/tail forward.c > > Log: > > Since kqueue support was added to tail, the "-F" option (check for > > renames/rotations) only detected cases where the file itself was > > moved or deleted. If part of the path to the file (or a symlink > > in the path) was changed instead, tail would not notice. > > > > Fix this by ensuring that we stat the path at least once every > > second in the -F case to check for changes. We still use kqueue > > when possible to inform us quickly when the file has changed. > > Hmm, this strikes me as a bit nasty...ideally you shouldn't have to poll > for any status changes in a kqueue world. Is there an easy way kq could > be improved to handle this? Note that, regardless of kq supporting non-polling, most applications need to know how to poll anyway so as to support non-local file systems that don't send around event information (nfs, etc). tail has such logic for nonkqe-aware file systems, and others will need it also. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1011125175449.74761B-100000>