Date: Fri, 15 Nov 2002 19:17:42 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: Brian Feldman <green@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 21079 for review Message-ID: <Pine.NEB.3.96L.1021115191246.62811D-100000@fledge.watson.org> In-Reply-To: <200211151843.gAFIhTNU019175@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Generally looks good, but a couple of questions below.
On Fri, 15 Nov 2002, Brian Feldman wrote:
> Add three new checks for kernel modules:
> mac_check_kldload(cred, vnode)
> mac_check_kldunload(cred)
> mac_check_kldobserve(cred)
The naming seems a bit inconsistent here -- in some places it's in the
system namespace. I'd be tempted to rename them as:
mac_check_kld_load()
mac_check_kld_stat()
mac_check_kld_unload()
> int
> +mac_check_system_kldload(struct ucred *cred, struct vnode *vp)
> +{
> + int error;
> +
> + if (vp != NULL) {
> + ASSERT_VOP_LOCKED(vp, "mac_check_system_acct");
> + }
Two questions:
(1) Can vp ever be NULL here? If so, when and why?
(2) Looks like a copy-and-paste-o: should be kldload not acct.
> + if (!mac_enforce_system)
> + return (0);
Adam's recent comments about "system" vs "kld" sound good.
> @@ -556,6 +558,13 @@
> if (error)
> return error;
> NDFREE(&nd, NDF_ONLY_PNBUF);
> +#ifdef MAC
> + error = mac_check_system_kldload(curthread->td_ucred, nd.ni_vp);
> + if (error) {
> + firstpage = NULL;
> + goto out;
It looks like you can only get here if the vn_open() succeeds, suggesting
vp will always be non-NULL. If the goal is to leave the door open for
other potential sources of linker data later, I suggest we just handle
that case with a different entry point in the event that happens.
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021115191246.62811D-100000>