Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jul 2012 08:37:30 +0400
From:      Eygene Ryabinkin <rea@freebsd.org>
To:        Henry Hu <henry.hu.sh@gmail.com>, Doug Barton <dougb@FreeBSD.org>
Cc:        ports@freebsd.org, Michael Scheidell <scheidell@freebsd.org>
Subject:   Re: cvs commit: ports/x11/slim Makefile pkg-plist ports/x11/slim/files pam.conf slim.sh.in
Message-ID:  <UmBSlluf1KZ6jxAvfrSQDLAnt1g@9WbtA8HxBG6suoSz1xgfAwGKIVs>
In-Reply-To: <5003CBAA.2040809@FreeBSD.org> <CAEJt7hbQwERZuNjmv6G9pKj62rb6d-EjzjVKMmvuSXLHBvzPzA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Thu, Jul 12, 2012 at 12:26:15AM -0400, Henry Hu wrote:
> For the png problem, I think that we can use png_jmpbuf for any
> libpng
> >=3D 1.2.5? It seems to be exist at least from libpng 1.2.5
> (http://www.libpng.org/pub/png/libpng-1.2.5-manual.html) so it's
> safe to use it?

Should be.  But according to the portability note at
  http://www.libpng.org/pub/png/libpng.html
"The libpng 1.5.x series continues the evolution of the libpng API,
finally hiding the contents of the venerable and hoary png_struct and
png_info data structures inside private (i.e., non-installed) header
files."  So it is normal to use the "new" API only for >=3D 1.5.x.

Mon, Jul 16, 2012 at 01:07:06AM -0700, Doug Barton wrote:
> > Yesterday I had looked at the libpng and it seems that this
> > patch should include 1.4.* for the new variant of the setjmp
> > code -- I need some hours to try to build it with png 1.4.
>=20
> Where are we at with this? I'm using the latest png with your patch and
> it is working fine, although only a few of my backgrounds are PNGs.

I had tested it with PNG 1.4.10 -- works fine.  So, I had changed
the required library version for png from '15' to '1[45]'.  The patch
was modified accordingly,
  http://codelabs.ru/fbsd/ports/slim/upgrade-1.3.3-to-1.3.4.diff
--=20
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

--X1bOJ3K7DJ5YkBrT
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iF4EABEIAAYFAlAGPYkACgkQFq+eroFS7PtIWQEAlmoLekeBj3YEXInl6sGedDvT
Rikwk5bKSEpvKv+fsA4A/0r7yQcCkq4nY13Ihid3B0xbaZ9/31jx9noKZw/JtjXF
=ydyO
-----END PGP SIGNATURE-----

--X1bOJ3K7DJ5YkBrT--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?UmBSlluf1KZ6jxAvfrSQDLAnt1g>