Date: Tue, 04 Sep 2001 00:28:28 -0400 (EDT) From: Mike Heffner <mheffner@vt.edu> To: chrisw@Wicklein.ORG Cc: current@FreeBSD.ORG, kris@FreeBSD.ORG Subject: RE: syslogd: Too many '/' in "/dev//console" Message-ID: <XFMail.20010904002828.mheffner@vt.edu> In-Reply-To: <20010903204142.87BDC37B405@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 03-Sep-2001 chrisw@Wicklein.ORG wrote:
| Between last weekend and this weekend, something changed in syslogd
| seems to have resulted in this boot-time error. The syslogd.c deltas
| from 1.82 -> 1.83 look suspect since the handling of relevant variables
| has changed.
This change looks wrong:
@@ -1679,16 +1659,17 @@ cfline(line, f, prog, host)
f->f_type = F_CONSOLE;
else
f->f_type = F_TTY;
- (void)strcpy(f->f_un.f_fname, p + sizeof _PATH_DEV - 1);
+ (void)strlcpy(f->f_un.f_fname, p + sizeof(_PATH_DEV - 1),
^^^^^^^^^^^^^^^
+ sizeof(f->f_un.f_fname));
} else {
Mike
--
Mike Heffner <mheffner@[acm.]vt.edu>
Blacksburg, VA <mikeh@FreeBSD.org>
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD4DBQE7lFhrFokZQs3sv5kRAogCAJdNTWYuavX+gDJx9ykLFan2R5k+AJ46jbBk
QApJOOEVMWdved+b285e1A==
=BsGB
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010904002828.mheffner>