Date: Fri, 29 Mar 2002 11:33:50 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Jon Mini <mini@haikugeek.com> Cc: freebsd-smp@freebsd.org Subject: RE: [PATCH] Hold PROC lock while accessing proc's pargs Message-ID: <XFMail.20020329113350.jhb@FreeBSD.org> In-Reply-To: <20020329031413.A413@stylus.haikugeek.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29-Mar-2002 Jon Mini wrote: >> alfred 2002/03/27 13:36:18 PST >> >> Modified files: >> sys/sys proc.h >> sys/compat/svr4 svr4_misc.c >> sys/kern kern_exec.c kern_exit.c kern_fork.c >> kern_proc.c >> Log: >> Make the reference counting of 'struct pargs' SMP safe. >> >> There is still some locations where the PROC lock should be held >> in order to prevent inconsistent views from outside (like the >> proc->p_fd fix for kern/vfs_syscalls.c:checkdirs()) that can be >> fixed later. >> >> Submitted by: Jonathan Mini <mini@haikugeek.com> >> >> Revision Changes Path >> 1.43 +1 -2 src/sys/compat/svr4/svr4_misc.c >> 1.158 +2 -6 src/sys/kern/kern_exec.c >> 1.153 +1 -2 src/sys/kern/kern_exit.c >> 1.142 +1 -2 src/sys/kern/kern_fork.c >> 1.122 +5 -7 src/sys/kern/kern_proc.c >> 1.213 +51 -0 src/sys/sys/proc.h > > > This patch does that: > > http://www.haikugeek.com/freebsd/pargs.diff You don't need PROC_LOCK for p_comm, so you can drop it prior to the sbuf_printf. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020329113350.jhb>