Date: Sat, 18 May 2002 23:20:13 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Jeff Roberson <jroberson@chesapeake.net> Cc: Jeff Roberson <jeff@FreeBSD.org>, Peter Wemm <peter@wemm.org>, Perforce Change Reviews <perforce@FreeBSD.org>, Julian Elischer <julian@elischer.org>, Jonathan Mini <mini@FreeBSD.org> Subject: Re: PERFORCE change 11120 for review Message-ID: <XFMail.20020518232013.jhb@FreeBSD.org> In-Reply-To: <20020518230944.I49505-100000@mail.chesapeake.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-May-2002 Jeff Roberson wrote: > On Sat, 18 May 2002, Jonathan Mini wrote: > >> John Baldwin [jhb@FreeBSD.org] wrote : >> >> > > On Fri, 17 May 2002, John Baldwin wrote: >> > > >> > >> Yes, I think that is the problem. I think it has to do with setting >> > >> up/tearing down the thread stacks. If uma could do this w/o holding >> > >> the zone locks that would probably be sufficient. >> > > >> > > The old analogy to this problem was one of the reasons that I used >> > > the thread_reap() command an allowed them to be torn down >> > > at a known safe time.. >> > >> > The fini() call out should be a safe time, I think the locking in uma >> > just needs to be adjusted to ensure it is safe. >> >> I think Jeff agrees as well. >> >> Jeff, are you reading this thread? > > The fini call happens w/o the zone lock being held. The init could be > called w/o the zone lock being held as well if this is important. I > haven't seen this whole thread though. What is the issue? And what is the > desired behavior? Yes, having init() called w/o it would be good since I think init() is the one that can actually block. For threads the init/fini setup and teardown thread stacks and the actual operation to do a thread stack teardown/setup can block so we need to not hold any locks when we do that. > Thanks, > Jeff -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020518232013.jhb>