Date: Mon, 20 May 2002 14:20:19 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/vm uma_core.c Message-ID: <XFMail.20020520142019.jhb@FreeBSD.org> In-Reply-To: <200205201754.g4KHsnS42281@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20-May-2002 John Baldwin wrote: > jhb 2002/05/20 10:54:48 PDT > > Modified files: > sys/vm uma_core.c > Log: > In uma_zalloc_arg(), if we are performing a M_WAITOK allocation, ensure > that td_intr_nesting_level is 0 (like malloc() does). Since malloc() calls > uma we can probably remove the check in malloc() for this now. Also, > perform an extra witness check in that case to make sure we don't hold > any locks when performing a M_WAITOK allocation. This revealed a lot of possible brokenness: > grep 'could' foo | sed -e 's/^.*could/could/' | sort | uniq -c | sort -nr 44 could sleep with "pcm0" locked from ../../../dev/sound/pcm/sound.c:134 25 could sleep with "UMA lock" locked from ../../../vm/uma_core.c:1157 10 could sleep with "process lock" locked from ../../../kern/kern_prot.c:511 10 could sleep with "pccbb0" locked from ../../../dev/pccbb/pccbb.c:891 9 could sleep with "pcm0:play:3" locked from ../../../dev/sound/pcm/channel.c:677 9 could sleep with "pcm0:mixer" locked from ../../../dev/sound/pcm/sound.c:134 6 could sleep with "pcm0:play:1" locked from ../../../dev/sound/pcm/channel.c:677 5 could sleep with "process lock" locked from ../../../kern/kern_prot.c:613 5 could sleep with "pcm0:play:2" locked from ../../../dev/sound/pcm/channel.c:677 5 could sleep with "pcm0:play:0" locked from ../../../dev/sound/pcm/channel.c:677 4 could sleep with "rl0" locked from ../../../pci/if_rl.c:855 4 could sleep with "rl0" locked from ../../../pci/if_rl.c:587 4 could sleep with "pcm0:fake" locked from ../../../dev/sound/pcm/channel.c:677 3 could sleep with "sf_bufs list lock" locked from ../../../kern/uipc_syscalls.c:1578 2 could sleep with "rman" locked from ../../../kern/subr_rman.c:194 2 could sleep with "rl0" locked from ../../../pci/if_rl.c:1413 1 could sleep with "rl0" locked from ../../../pci/if_rl.c:1524 -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020520142019.jhb>