Date: Fri, 31 Jan 2003 13:31:23 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, "Tim J. Robbins" <tjr@FreeBSD.org> Subject: RE: cvs commit: src/sys/kern subr_trap.c Message-ID: <XFMail.20030131133123.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0301310949360.45015-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31-Jan-2003 Julian Elischer wrote:
>
> do you know of any other problems?
thread_statclock() has a similar problem as others have noticed:
int
thread_statclock(int user)
{
struct thread *td = curthread;
...
if (td->td_mailbox != NULL)
td->td_usticks += ticks;
}
Prior to this commit, the 'ticks' variable was an argument to this
function, now it is using the global variable instead. This is
clearly wrong and along with the other breakages this commit has
introduced so far demonstrate a severe lack of testing or review
in this commit. We want to make RELENG_5 more stable as we approach
5.1 not less if possible. There is nothing preventing you from
doing development work in side trees and only committing it when it
is tested and has been properly reviewed. Please back these changes
out and work on them locally until you have tested them and fully
reviewed them.
>
> On Fri, 31 Jan 2003, John Baldwin wrote:
>
>>
>> On 31-Jan-2003 Tim J. Robbins wrote:
>> > tjr 2003/01/31 03:22:32 PST
>> >
>> > Modified files:
>> > sys/kern subr_trap.c
>> > Log:
>> > Use a local variable to store the number of ticks that elapsed in
>> > kernel mode instead of (unintentionally) using the global `ticks'.
>> > This error completely broke profiling.
>>
>> Perhaps we should really back out the 'upcall' change until the patch
>> has has some more review and bugs like this have been fixed.
>>
>> --
>>
>> John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
>> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
>>
>
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030131133123.jhb>