Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Jul 2008 11:14:01 +0100
From:      "Florent Thoumie" <flz@xbsd.org>
To:        osvaldsson@icelandic.net
Cc:        ports@freebsd.org, pgollucci@freebsd.org, araujo@freebsd.org
Subject:   Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes
Message-ID:  <a01628140807230314r247cd0b2h5da1138ca0a5b67@mail.gmail.com>
In-Reply-To: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry>
References:  <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 22, 2008 at 11:41 PM, Olafur Osvaldsson
<osvaldsson@icelandic.net> wrote:
> Why has committing a patch gotten so complicated?

One day since the last update to the PR... The PR responsible recently
got repository privileges so he's probably getting familiar to the
procedures.

While I'm looking at it, you're checking if NO_INSTALL_MANPAGES which
is wrong. This variable is meant to be set by ports, not users. Even
if it were, you would end up with a incomplete packing list, because
your port installs manual pages unconditionally. I'd suggest getting
rid of the check completely.

-- 
Florent Thoumie
flz@FreeBSD.org
FreeBSD Committer



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a01628140807230314r247cd0b2h5da1138ca0a5b67>