Date: Mon, 3 Apr 2023 21:26:05 +1000 From: Peter Grehan <grehan@freebsd.org> To: =?UTF-8?Q?Corvin_K=c3=b6hne?= <corvink@FreeBSD.org> Cc: virtualization@FreeBSD.org Subject: Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables Message-ID: <a2e19eb1-bb85-84f6-f805-c8065076bbf0@freebsd.org> In-Reply-To: <20230331123936.540020-1-corvink@FreeBSD.org> References: <20230331123936.540020-1-corvink@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Corvin, > I would like to send the following patch to the EDKII project. > Therefore, I'd like to get some feedback from the bhyve community before > sending them to EDKII. Thanks for giving a heads-up. The patch looks fine to me. The only minor suggestion I have is to use the qemu fwcfg interface to locate the RSDP instead of searching through memory, since presumably any new ACPI table functionality in bhyve would be after this point in time where qemu fwcfg is already supported. later, Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a2e19eb1-bb85-84f6-f805-c8065076bbf0>