Date: Fri, 4 Aug 2017 09:48:38 -0400 From: Nikolai Lifanov <lifanov@FreeBSD.org> To: freebsd-ruby@freebsd.org Cc: Torsten Zuehlsdorff <tz@FreeBSD.org> Subject: Re: [Stage-QA] Gemfile-Check - WIP Message-ID: <af4bc3fd-57c6-6501-a216-72282e5ec949@FreeBSD.org> In-Reply-To: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org> References: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--PbFiLwTKWmafCDv4qaksdSvdMQas7haBx
Content-Type: multipart/mixed; boundary="lHMxEP62DKDDgOVFAia6c7UnIDGKlvOk9";
protected-headers="v1"
From: Nikolai Lifanov <lifanov@FreeBSD.org>
To: freebsd-ruby@freebsd.org
Cc: Torsten Zuehlsdorff <tz@FreeBSD.org>
Message-ID: <af4bc3fd-57c6-6501-a216-72282e5ec949@FreeBSD.org>
Subject: Re: [Stage-QA] Gemfile-Check - WIP
References: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org>
In-Reply-To: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org>
--lHMxEP62DKDDgOVFAia6c7UnIDGKlvOk9
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 8/4/17 8:51 AM, Torsten Zuehlsdorff wrote:
> Aloha,
>=20
> inspired by lifanov and his work in PR 220605 to add a check for
> .gemspec of rubygems i tried myself with Gemfile.
>=20
> Background is, that checking the actual Gemfile of non rubygem-* ports
> is often very time-consuming. When building Gitlab, Redmine or others,
> everything is fine. But when executing they fail - because the Gemfile
> is not satisfied.
>=20
> Its WIP and my first try for an stage-qa script, so every comment is
> appreciated. It adds a stage-qa stage for every non rubygem- port. When=
> executed i (intent) to scan for Gemfiles and checking every file with
> bundle check. If bundle fails, the stage-qa fails.
>=20
> It worked for simple test. If no Gemfile was present the test was
> skipped. If it is, bundle is executed. When removing a needed dependenc=
y
> it is found. Its also found when the dependency is indirect (not in
> Gemfile itself, but a dependency of an dependency listed there).
>=20
> But it don't work for net-im/mikutter for example and i don't know why.=
>=20
> So any feedback would be fine! :)
>=20
> Greetings,
> Torsten
>=20
Hi!
I think for something like this, a better initial approach is to make
this stage-qa target non-fatal, so warnings instead of errors.
At least initially it will cause less disruption and give porters an
opportunity to fix the errors.
I have two thoughts on it so far:
$(find ${STAGEDIR} -name Gemfile) is pretty heavy to do on every port.
Can we export something to QA_ENV from USE_RUBY and check for this instea=
d?
Is "bundle" guaranteed to be installed for ports that ship a Gemfile?
Otherwise, it looks good and only has minor nits. Can we move this to
Phabricator? This will make it easier to review and iterate on.
Thank you!
- Nikolai
--lHMxEP62DKDDgOVFAia6c7UnIDGKlvOk9--
--PbFiLwTKWmafCDv4qaksdSvdMQas7haBx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJIBAEBCAAyFiEE5oT6TcuaWvG5gtjzZ6sv56ecR0UFAlmEezcUHGxpZmFub3ZA
ZnJlZWJzZC5vcmcACgkQZ6sv56ecR0VWuw/8DXvtR9bqhryqpqRvXcNOorK+sL+D
F7uDETsKpVPBWsXuBPyOMBbXYuUyXky1N3/goWn8CdMwMyXCw9qDCOve7SqIFH/T
IRdcPwjbV1tyKInJvmy47AlLofALeNiEJJillR5FFPDtX5ZmWfOFhXb2LfVBStZd
pM5DYgj3KnDJw3ihqsbxCElD704aqtJ0+DUhRTO0+WVjoUS6YzR5/MfRh68BoZ9i
D/Hk1s18o0KWyqyF4+qChvT4LnJWoQhTFJJHhbsKIoHnZhoSRFy5mE9TdNEXyN5t
vS+EdEsdQgMwJgUaw3UzJXIlPMftVkZC8fgjD8AcrdpPYILWdpu5UO71xxdexJWZ
yomfNTsrJr1OSAQ73HMIkY/JaizJuurG3UxXQ/IZJDnDIhcpblxWzs4hL6iZSGbf
jBV0m6a/AgIEUAAv0KOceJ1qQePyUdNpowKip6wD0zz6s3O+c/oOnP7ERO68fr31
LReg4hh8cdirdExI0joNtr/xC9V1KtjlF6+pqvOPXeywoyCdVgvAX3St2yJgXC3q
5FbnsxHqyk4bbdhBraGU++4s0M0FXYgQum3Z6zNElAMb++JIpoaHv+cMLJ2PBHAW
LookNS93il87qP8TkhiEC1CdQO2bL6Dvruh51PiXlMZSx1vsOQVnSOzoCtPdf7Uw
Tp8YDQ+06pKaF/M=
=hfWU
-----END PGP SIGNATURE-----
--PbFiLwTKWmafCDv4qaksdSvdMQas7haBx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?af4bc3fd-57c6-6501-a216-72282e5ec949>