Date: Sat, 16 Nov 2013 16:19:52 +0100 (CET) From: Melvyn Sopacua <melvyn@magemana.nl> To: Stefan Esser <se@freebsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: Proposal for Authors / Vendors in ports Message-ID: <alpine.BSF.2.00.1311161601010.97748@fire.magemana.nl> In-Reply-To: <5285DA85.3040008@freebsd.org> References: <5283E4A0.6090107@pcbsd.org> <alpine.BSF.2.00.1311132124560.48376@fire.magemana.nl> <CAF6rxgmdewA=jtWL-8dyGrzSFTkxM2P8jWDYYcXr4BXOEdgx_w@mail.gmail.com> <20131114073008.GG90670@droso.dk> <9D6E2358-4750-41D5-9B8C-F638C8B1E351@xs4all.nl> <CAF6rxgkJzj7YbBEuxOhTdMmb0NwZsgN-08OuMacT2ad%2BP=wSuQ@mail.gmail.com> <5285CC00.6010800@FreeBSD.org> <5285DA85.3040008@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 15 Nov 2013, Stefan Esser wrote: > Am 15.11.2013 08:23, schrieb Matthew Seaman: >> On 15/11/2013 00:54, Eitan Adler wrote: >>> On Thu, Nov 14, 2013 at 5:41 PM, Jaap Akkerhuis >>> <jaapna@xs4all.nl> wrote: >>>> >>>> On Nov 14, 2013, at 8:30, Erwin Lansing <erwin@freebsd.org> >>>> wrote: >>>> >>>>> That sounds like an excellent idea. I'm just a bit worried >>>>> about spreading the information over too many places, and >>>>> would rather split content from logic and add these to >>>>> pkg-descr as well next to the current WWW. I know we're not >>>>> consistent already with things like COMMENT and LICENSE >>>>> already in the Makefile, so won't ojbect too much to where >>>>> these end up. >>>> >>>> Apart from spreading this information into to many places >>>> (pkg_desc seams a proper place to have such information), why >>>> have the Makefile double up as a database? >>> >>> pkg_descr is free form. Makefiles are parsable (make -V). >> >> pkg_descr is only as free-form as we define it to be. It's a lot >> quicker to parse out the WWW entry from pkg_descr than it is to >> run 'make -V' to extract values from port Makefiles. That's >> because make includes and parses a whole stack of different files >> from /usr/ports/Mk and elsewhere and does a bunch of other >> processing -- takes about 200ms per port just to print out the >> variables used in the INDEX. +1. I also fail to see the upside of adding extra variables to the makefiles. Requestor of this feature already hinted it's going to be queried using the pkg command, so all it needs is a pkg command that can parse a single line into 2 meaningful chunks, using well-defined delimiters. In addition, there's no descision being made based upon these variables in the building/installation process. >> So, unless the variable is needed as part of the build process for >> a port putting it in pkg_decr makes sense to me. This could >> include some well-known values like MAINTAINER if we want to go >> that far. > > Two comments: > > 1) I think that pkg-descr contains information about the ported > software, not the port. I.e. the web-site, the organisation, or > the license are good candidates for pkg-descr. The maintainer > or other information that does not relate to the ported software > itself but just to how it is managed in the FreeBSD ports tree > should be kept in some other place. (IMHO) License is used in port building logic. Adding more metadata to pkg-descr fills up the 4k holes mentioned earlier in the thread and adds possibilities for sites like freshports to add more content with minimal effort. Since metadata and description are words with similar meaning, I don't see a need for a name change or new file, as proposed earlier. > > 2) If meta-information is moved to pkg-descr, it might be worthwhile > to add some knowledge about formats and restrictions to portlint. +1 -- Melvyn Sopacua
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1311161601010.97748>