Date: Sat, 4 Feb 2017 23:24:33 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: John Marino <marino@freebsd.org> Cc: Matthias Andree <matthias.andree@gmx.de>, ports-committers@freebsd.org, freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: svn commit: r432796 - in head/graphics: rawtherapee rawtherapee-devel Message-ID: <alpine.LSU.2.20.1702042323090.2253@anthias.pfeifer.com> In-Reply-To: <9c122c71-bc24-0ed4-e671-be49ab06431b@marino.st> References: <201701291922.v0TJMlQE038923@repo.freebsd.org> <f2e8dfd9-3d5d-668a-47c3-f7f50b1b9917@gmx.de> <9c122c71-bc24-0ed4-e671-be49ab06431b@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 3 Feb 2017, John Marino wrote:
> AFAIK it's not documented, but it's been spoken here quite a few times
> and the result was "try to be nice and if you must use OSVERSION, guard
> it with OPSYS". Anything else is a bug because OSVERSION only makes
> sense with an exact value of OPSYS ("FreeBSD").
Would it make sense to add a check to portlint that every condition
(or practically probably line, considering "...\\\n..." as one line)
that has OSVERSION also has OPSYS?
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.20.1702042323090.2253>