Date: Sun, 28 May 2017 01:37:07 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Joe Nosay <superbisquit@gmail.com>, java@freebsd.org Subject: Re: Remove dead code from java/cacao/Makefile Message-ID: <alpine.LSU.2.21.1705280131360.3529@anthias.pfeifer.com> In-Reply-To: <CA%2BWntOu5d7avfVhoa-Y2a7dghQBHU8PizyRsjN1eCHe49Sz6QA@mail.gmail.com> References: <alpine.LSU.2.21.1705142235120.4477@anthias.pfeifer.com> <CA%2BWntOu5d7avfVhoa-Y2a7dghQBHU8PizyRsjN1eCHe49Sz6QA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Joe, and thanks for the detailed response. On Sun, 14 May 2017, Joe Nosay wrote: >> Okay to apply? > Do not remove that option. There are other java kits and code that is > open source. There was and should still be a Java JIT application with > llvm/CLang. I did not propose to remove that option, I merely wanted to relay that (a) currently this alternative codepath is simply broken and (b) remove three lines of dead code at least. > Just comment the option so that it is not used. > Use IceTea in the bootstrap. > You will need to create and recreate all of the open non-propritary > libraries, binaries, links, suites, and applications this way. > Bootstrap and create the path layouts according to the same $PATH and > $CLASSPATH of the standard Oracle-Sun Java Development Environment. > > Save everything. > Set this up as a script. > Make a complete package. > Submit what you have done > to: info@freebsd.org as an email That's a lot more than I'm up to, I'm afraid. However, the patch below still makes sense and removes dead code. Okay to apply this? (Another change to bring this closer to even have a chance of working is adjusting GCC_SUFX?=46 to GCC_SUFX?=5. I can guarantee that 46 has zero chance of working, even theoretically.) But, one thing at a time. Can you, or someone else, please approve the three-liner below to simplify this? Gerald Index: java/cacao/Makefile =================================================================== --- java/cacao/Makefile (revision 441883) +++ java/cacao/Makefile (working copy) @@ -36,9 +36,6 @@ JAR= ${LOCALBASE}/bootstrap-openjdk/bin/jar JAVAC= ${LOCALBASE}/bootstrap-openjdk/bin/javac .else -.if defined(WITH_GCC) -GCC_SUFX= ${WITH_GCC:S/.//} -.endif GCC_SUFX?= 46 BUILD_DEPENDS+= gcj${GCC_SUFX}:lang/gcc${GCC_SUFX} EXTRA_PATCHES= ${FILESDIR}/gcj.patch
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1705280131360.3529>