Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 May 2018 05:48:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 210316] panic after trying to r/w mount msdosfs on write protected media
Message-ID:  <bug-210316-3630-eXVbCR5qFd@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-210316-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-210316-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210316

--- Comment #14 from Andriy Gapon <avg@FreeBSD.org> ---
(In reply to Conrad Meyer from comment #13)

Indeed, if we talk about the general behaviour.

I see that I utterly failed to explain that I was thinking purely in a cont=
ext
of what msdos does in markvoldirty.
Right now that code can leave behind a perpetually dirty buffer and I was
thinking how that can be avoided.

Maybe markvoldirty should do
    bp =3D getblk(...)
    bp->b_flags |=3D B_INVAL | B_RELBUF | B_NOCACHE;
    bp->b_flags &=3D ~(B_ASYNC | B_CACHE);
    brelse(bp);
after a failed write?
Looks clumsy, but should work.

Or maybe markvoldirty should not use buffer cache for its write?
It could use g_write_data, for example.  But that sounds like layering
violation.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210316-3630-eXVbCR5qFd>