Date: Fri, 21 Jan 2022 13:34:19 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: loader <loader@freebsd.org>, Stefan Esser <se@FreeBSD.org> Cc: python@freebsd.org Subject: Re: PLIST issues in more ports? Message-ID: <c8503a0d-dd4b-f86c-a0dc-69d5160e2383@FreeBSD.org> In-Reply-To: <20220116152934.D2BEC10CD2@freefall.freebsd.org> References: <fa809b14-d53a-876a-94e3-de650fab1034@FreeBSD.org> <20220116152934.D2BEC10CD2@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17/01/2022 2:29 am, loader wrote:
> On Sat, 15 Jan 2022 01:28:09 +0100, Stefan Esser <se@FreeBSD.org> wrote:
>
>> Hi Python Maintainers,
>>
>> the following packages conflict with each other since they install
>> files that do not depend on the package:
>>
>> py38-scikit-bio
>> py38-ddtrace
>>
>> They contain files like
>>
>> lib/python3.8/site-packages/benchmarks/__pycache__/__init__.cpython-38.pyc
>>
>> which probably should be excluded from the PLIST.
>>
>> Similarily:
>>
>> py38-mycli
>> py38-beziers
>> py38-grizzled
>> py38-gtfslib
>> py38-habanero
>> py38-molecule
>> py38-onnx-tf
>> py38-ont-fast5-api
>> py38-puppetboard
>> py38-pysmartdl
>> py38-pysodium
>> py38-pyzipper
>> py38-streamparse
>>
>> which all contain:
>>
>> lib/python3.8/site-packages/test/__init__.py
>> lib/python3.8/site-packages/test/conftest.py
>> lib/python3.8/site-packages/test/__pycache__/__init__.cpython-38.pyc
>> lib/python3.8/site-packages/test/__pycache__/conftest.cpython-38.pyc
>>
>> I have not checked for individual maintainers, but this is IMHO a
>> framework issue that should have a generic solution ...
>>
>> Should I create a PR for this issue?
>>
>> Regards, STefan
>
> Just a thought, maybe site-packages/test/ could be removed during
> autoplist, but not sure whether there's a port really needs be to
> installed into this directory.
>
> diff --git a/Mk/Uses/python.mk b/Mk/Uses/python.mk
> index 6c5d11dc9d08..37aa53759698 100644
> --- a/Mk/Uses/python.mk
> +++ b/Mk/Uses/python.mk
> @@ -616,6 +616,7 @@ _RELLIBDIR= ${PYTHONPREFIX_LIBDIR:S;${PREFIX}/;;}
> _USES_stage+= 934:add-plist-pymod
> add-plist-pymod:
> @${SED} -e 's|^"\(.*\)"$$|\1|' \
> + -e '\|^${PYTHON_SITELIBDIR}/test/|d' \
> -e 's|^${STAGEDIR}${PREFIX}/||' \
> -e 's|^${PREFIX}/||' \
> -e 's|^\(man/.*man[0-9]\)/\(.*\.[0-9]\)$$|\1/\2.gz|' \
>
> Cheers,
> loader
Ideally and if possible, these issues should be (1) detected (sanity.mk
python.mk or similar: fatal error) and (2) reported upstream so that
they can be resolved permanently.
Happy to discuss any time. #freebsd-python @ Libera Chat IRC
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c8503a0d-dd4b-f86c-a0dc-69d5160e2383>