Date: Fri, 17 Jan 2020 14:57:32 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Shichun.Ma@dell.com, freebsd-usb@freebsd.org Cc: Jason_YH_Yang@wistron.com Subject: Re: USB keyboard/mouse wake up from S3 Message-ID: <ce7a1eea-ca93-8344-e077-ef7ce68d6498@selasky.org> In-Reply-To: <a96a122f-6736-8af0-621f-e70b799593ed@selasky.org> References: <1578625588784.46788@Dell.com> <47257477-bace-a9c5-69f5-7a0eb7af3947@selasky.org> <1578648297338.92657@Dell.com> <685f991f-6cb6-3f27-65d8-38181e4cfa8e@selasky.org> <1579231397567.62223@Dell.com> <a96a122f-6736-8af0-621f-e70b799593ed@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-01-17 10:41, Hans Petter Selasky wrote: > On 2020-01-17 04:23, Shichun.Ma@dell.com wrote: >> >> HPS, >> >> Here is my patch to enable USB wakeup under XHCI, I tested USB >> mouse/keyboard can wake up system from S3. >> > > Hi, > > Patches look OK, with some minor nits. > > Have you thought about adding EHCI/OHCI/UHCI to the wakeup matrix aswell? > > How many different computers and CPU architectures has this code been > tested with? > Also I want you to add a sysctl, hw.usb.no_wakeup, which if set, preserves the old behaviour. Thank you! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ce7a1eea-ca93-8344-e077-ef7ce68d6498>