Date: Sun, 1 Dec 2024 08:51:50 -0500 From: Mike Jakubik <mike.jakubik@gmail.com> To: Ronald Klop <ronald-lists@klop.ws> Cc: freebsd-net@freebsd.org, ale@FreeBSD.org Subject: Re: FreeBSD Port: net/realtek-re-kmod Message-ID: <d3bcb620-5a63-4355-87cc-f77c62bb75ac@gmail.com> In-Reply-To: <1944158676.16135.1733047112928@localhost> References: <b945f01a-6128-4d28-84b3-883ed388a994@gmail.com> <1944158676.16135.1733047112928@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------PllPy9W4bIfNcIj3JYzhqn04 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Oh OK, sorry missed that, will test and report. Thanks! On 2024-12-01 4:58 a.m., Ronald Klop wrote: > I think a quick fix for your problem was committed a few days ago (Nov > 28). > > https://cgit.freebsd.org/ports/commit/?id=4ca9ea9d4060a4a494456a0e56306bd508fe20e8 > > Regards, > Ronald. > > *Van:* Mike Jakubik <mike.jakubik@gmail.com> > *Datum:* zondag, 1 december 2024 01:59 > *Aan:* ale@FreeBSD.org, freebsd-net@freebsd.org > *Onderwerp:* FreeBSD Port: net/realtek-re-kmod > > Any update on this from upstream maybe? Seems like an easy fix, I > got new system that needs this driver too (Realtek 5Gb). > > Ty. > > > Hello, > > > Seems like it wont compile on recent current, noticed about 2 days > ago and /usr/src/sys/sys/mbuf.h hasnt been touched it seems. > > 15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-56043cbfdd: Thu Nov 21 > 20:30:44 EST 2024 > > > [root@fbsd15 /usr/ports/net/realtek-re-kmod]# make > MAKE_JOBS_UNSAFE=yes > ===> Building for realtek-re-kmod-1100.00_1 > Warning: Object directory not changed from original > /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e > cc -O2 -pipe -fno-strict-aliasing -DENABLE_INTERRUPT_MITIGATIN > -Werror -D_KERNEL -DKLD_MODULE -nostdinc -include > /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e/opt_global.h > -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common > -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer > -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include > -fdebug-prefix-map=./x86=/usr/src/sys/x86/include > -fdebug-prefix-map=./i386=/usr/src/sys/i386/include -MD > -MF.depend.if_re.o -MTif_re.o -mcmodel=kernel -mno-red-zone > -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables > -ffreestanding -fwrapv -fstack-protector -Wall > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith > -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pragmas -Wswitch > -Wno-error=tautological-compare -Wno-error=empty-body > -Wno-error=parentheses-equality -Wno-error=unused-function > -Wno-error=pointer-sign -Wno-error=shift-negative-value > -Wno-address-of-packed-member -Wno-format-zero-length -mno-aes > -mno-avx -std=gnu99 -c if_re.c -o if_re.o > if_re.c:1270:37: error: incomplete definition of type 'struct ifnet' > 1270 | sc->re_rx_desc_buf_sz = (ifp->if_mtu > ETHERMTU) ? > ifp->if_mtu: ETHERMTU; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:1270:63: error: incomplete definition of type 'struct ifnet' > 1270 | sc->re_rx_desc_buf_sz = (ifp->if_mtu > ETHERMTU) ? > ifp->if_mtu: ETHERMTU; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:4562:60: error: incomplete definition of type 'struct ifnet' > 4562 | printf("if_drv_flags\t0x%08x\n", > sc->re_ifp->if_drv_flags); > | ~~~~~~~~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:4622:43: error: call to undeclared function 'IF_LLADDR'; > ISO C99 and later do not support implicit function declarations > [-Werror,-Wimplicit-function-declaration] > 4622 | printf("dev_addr\t%6D\n", > IF_LLADDR(sc->re_ifp), ":"); > | ^ > if_re.c:4622:43: error: format specifies type 'void *' but the > argument has type 'int' [-Werror,-Wformat] > 4622 | printf("dev_addr\t%6D\n", > IF_LLADDR(sc->re_ifp), ":"); > | ~~~ ^~~~~~~~~~~~~~~~~~~~~ > if_re.c:4662:32: error: incomplete definition of type 'struct ifnet' > 4662 | if ((sc->re_ifp->if_drv_flags & > IFF_DRV_RUNNING) == 0) { > | ~~~~~~~~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5522:12: error: incomplete definition of type 'struct ifnet' > 5522 | ifp->if_softc = sc; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5529:12: error: incomplete definition of type 'struct ifnet' > 5529 | ifp->if_mtu = ETHERMTU; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5530:12: error: incomplete definition of type 'struct ifnet' > 5530 | ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | > IFF_MULTICAST; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5531:12: error: incomplete definition of type 'struct ifnet' > 5531 | ifp->if_ioctl = re_ioctl; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5532:12: error: incomplete definition of type 'struct ifnet' > 5532 | ifp->if_output = ether_output; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5533:12: error: incomplete definition of type 'struct ifnet' > 5533 | ifp->if_start = re_start; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5538:20: error: incomplete definition of type 'struct ifnet' > 5538 | ifp->if_hwassist |= CSUM_TCP | CSUM_UDP; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5540:20: error: incomplete definition of type 'struct ifnet' > 5540 | ifp->if_hwassist |= RE_CSUM_FEATURES; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5541:12: error: incomplete definition of type 'struct ifnet' > 5541 | ifp->if_capabilities = IFCAP_HWCSUM | > IFCAP_HWCSUM_IPV6; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5544:20: error: incomplete definition of type 'struct ifnet' > 5544 | ifp->if_hwassist |= CSUM_TSO; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5545:20: error: incomplete definition of type 'struct ifnet' > 5545 | ifp->if_capabilities |= IFCAP_TSO; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5549:20: error: incomplete definition of type 'struct ifnet' > 5549 | ifp->if_hwassist &= ~(CSUM_IP6_TSO | > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > if_re.c:5552:20: error: incomplete definition of type 'struct ifnet' > 5552 | ifp->if_capabilities &= ~(IFCAP_TSO6 | > IFCAP_HWCSUM_IPV6); > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of > 'struct ifnet' > 139 | struct ifnet *ifp; /* network interface > tag belongs to */ > | ^ > fatal error: too many errors emitted, stopping now [-ferror-limit=] > 20 errors generated. > *** Error code 1 > > Stop. > make: stopped making "all" in > /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e > *** Error code 1 > > Stop. > make: stopped making "all" in /usr/ports/net/realtek-re-kmod > [root@fbsd15 /usr/ports/net/realtek-re-kmod]# > > > ------------------------------------------------------------------------ > > --------------PllPy9W4bIfNcIj3JYzhqn04 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <p>Oh OK, sorry missed that, will test and report.</p> <p>Thanks!<br> </p> <div class="moz-cite-prefix">On 2024-12-01 4:58 a.m., Ronald Klop wrote:<br> </div> <blockquote type="cite" cite="mid:1944158676.16135.1733047112928@localhost"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> I think a quick fix for your problem was committed a few days ago (Nov 28).<br> <br> <a href="https://cgit.freebsd.org/ports/commit/?id=4ca9ea9d4060a4a494456a0e56306bd508fe20e8" moz-do-not-send="true" class="moz-txt-link-freetext">https://cgit.freebsd.org/ports/commit/?id=4ca9ea9d4060a4a494456a0e56306bd508fe20e8</a><br>; <br> Regards,<br> Ronald.<br> <br> <p><strong>Van:</strong> Mike Jakubik <a class="moz-txt-link-rfc2396E" href="mailto:mike.jakubik@gmail.com"><mike.jakubik@gmail.com></a><br> <strong>Datum:</strong> zondag, 1 december 2024 01:59<br> <strong>Aan:</strong> <a class="moz-txt-link-abbreviated" href="mailto:ale@FreeBSD.org">ale@FreeBSD.org</a>, <a class="moz-txt-link-abbreviated" href="mailto:freebsd-net@freebsd.org">freebsd-net@freebsd.org</a><br> <strong>Onderwerp:</strong> FreeBSD Port: net/realtek-re-kmod</p> <blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px"> <div class="MessageRFC822Viewer" id="P"> <div class="TextPlainViewer" id="P.P">Any update on this from upstream maybe? Seems like an easy fix, I got new system that needs this driver too (Realtek 5Gb).<br> <br> Ty.<br> <br> <br> Hello,<br> <br> <br> Seems like it wont compile on recent current, noticed about 2 days ago and /usr/src/sys/sys/mbuf.h hasnt been touched it seems.<br> <br> 15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-56043cbfdd: Thu Nov 21 20:30:44 EST 2024<br> <br> <br> [root@fbsd15 /usr/ports/net/realtek-re-kmod]# make MAKE_JOBS_UNSAFE=yes<br> ===> Building for realtek-re-kmod-1100.00_1<br> Warning: Object directory not changed from original /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e<br> cc -O2 -pipe -fno-strict-aliasing -DENABLE_INTERRUPT_MITIGATIN -Werror -D_KERNEL -DKLD_MODULE -nostdinc -include /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -fdebug-prefix-map=./i386=/usr/src/sys/i386/include -MD -MF.depend.if_re.o -MTif_re.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wswitch -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length -mno-aes -mno-avx -std=gnu99 -c if_re.c -o if_re.o<br> if_re.c:1270:37: error: incomplete definition of type 'struct ifnet'<br> 1270 | sc->re_rx_desc_buf_sz = (ifp->if_mtu > ETHERMTU) ? ifp->if_mtu: ETHERMTU;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:1270:63: error: incomplete definition of type 'struct ifnet'<br> 1270 | sc->re_rx_desc_buf_sz = (ifp->if_mtu > ETHERMTU) ? ifp->if_mtu: ETHERMTU;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:4562:60: error: incomplete definition of type 'struct ifnet'<br> 4562 | printf("if_drv_flags\t0x%08x\n", sc->re_ifp->if_drv_flags);<br> | ~~~~~~~~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:4622:43: error: call to undeclared function 'IF_LLADDR'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]<br> 4622 | printf("dev_addr\t%6D\n", IF_LLADDR(sc->re_ifp), ":");<br> | ^<br> if_re.c:4622:43: error: format specifies type 'void *' but the argument has type 'int' [-Werror,-Wformat]<br> 4622 | printf("dev_addr\t%6D\n", IF_LLADDR(sc->re_ifp), ":");<br> | ~~~ ^~~~~~~~~~~~~~~~~~~~~<br> if_re.c:4662:32: error: incomplete definition of type 'struct ifnet'<br> 4662 | if ((sc->re_ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) {<br> | ~~~~~~~~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5522:12: error: incomplete definition of type 'struct ifnet'<br> 5522 | ifp->if_softc = sc;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5529:12: error: incomplete definition of type 'struct ifnet'<br> 5529 | ifp->if_mtu = ETHERMTU;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5530:12: error: incomplete definition of type 'struct ifnet'<br> 5530 | ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5531:12: error: incomplete definition of type 'struct ifnet'<br> 5531 | ifp->if_ioctl = re_ioctl;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5532:12: error: incomplete definition of type 'struct ifnet'<br> 5532 | ifp->if_output = ether_output;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5533:12: error: incomplete definition of type 'struct ifnet'<br> 5533 | ifp->if_start = re_start;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5538:20: error: incomplete definition of type 'struct ifnet'<br> 5538 | ifp->if_hwassist |= CSUM_TCP | CSUM_UDP;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5540:20: error: incomplete definition of type 'struct ifnet'<br> 5540 | ifp->if_hwassist |= RE_CSUM_FEATURES;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5541:12: error: incomplete definition of type 'struct ifnet'<br> 5541 | ifp->if_capabilities = IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5544:20: error: incomplete definition of type 'struct ifnet'<br> 5544 | ifp->if_hwassist |= CSUM_TSO;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5545:20: error: incomplete definition of type 'struct ifnet'<br> 5545 | ifp->if_capabilities |= IFCAP_TSO;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5549:20: error: incomplete definition of type 'struct ifnet'<br> 5549 | ifp->if_hwassist &= ~(CSUM_IP6_TSO |<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> if_re.c:5552:20: error: incomplete definition of type 'struct ifnet'<br> 5552 | ifp->if_capabilities &= ~(IFCAP_TSO6 | IFCAP_HWCSUM_IPV6);<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<br> 139 | struct ifnet *ifp; /* network interface tag belongs to */<br> | ^<br> fatal error: too many errors emitted, stopping now [-ferror-limit=]<br> 20 errors generated.<br> *** Error code 1<br> <br> Stop.<br> make: stopped making "all" in /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e<br> *** Error code 1<br> <br> Stop.<br> make: stopped making "all" in /usr/ports/net/realtek-re-kmod<br> [root@fbsd15 /usr/ports/net/realtek-re-kmod]#<br> <br> <br> </div> <hr></div> </blockquote> <br> </blockquote> </body> </html> --------------PllPy9W4bIfNcIj3JYzhqn04--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d3bcb620-5a63-4355-87cc-f77c62bb75ac>