Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Apr 2022 17:55:52 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        dandan@lysator.liu.se, freebsd-infiniband@freebsd.org
Cc:        kempe@lysator.liu.se
Subject:   Re: [PATCH] ibcore: allow passing NULL-pointers to ib_umem_release()
Message-ID:  <de6d5de3-d6e5-34cf-3a92-b3b65432eff9@selasky.org>
In-Reply-To: <20220429153345.Horde.6oVap54ZXOmz41donxfLJJ5@webmail.lysator.liu.se>
References:  <20220429153345.Horde.6oVap54ZXOmz41donxfLJJ5@webmail.lysator.liu.se>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/29/22 17:33, dandan@lysator.liu.se wrote:
> Hi!
> 
> The attached patch fixes the following kernel panic in ibcore when 
> unloading the mlx4ib kernel module:
> 

Hi!

I've queued the patch internally at Mellanox/Nvidia for review. Will 
submit it on Monday most likely.

Thank you!

--HPS

Slightly update commit message:

>     ibcore: Allow passing NULL-pointers to ib_umem_release()
>     
>     FreeBSD commit b633e08c705fe43180567eae26923d6f6f98c8d9 removed the
>     NULL-checks from the mlx4ib-driver.
>     
>     This fixes the following NULL-pointer panic when unloading mlx4ib:
>     ib_umem_release()
>     mlx4_ib_destroy_qp()
>     ib_destroy_qp_user()
>     ipoib_transport_dev_cleanup()
>     ipoib_dev_cleanup()
>     ipoib_remove_one()
>     ib_unregister_client()
>     ipoib_cleanup_module()
>     linker_file_sysuninit()
>     linker_file_unload()
>     kern_kldunload()
>     amd64_syscall()
>     
>     Linux commit:
>     836a0fbb3e76f704ad65ddfb57f00725245e509b
>     
>     Submitted by:   dandan@lysator.liu.se
>     Sponsored by:   Lysator ACS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?de6d5de3-d6e5-34cf-3a92-b3b65432eff9>