Date: Fri, 26 Dec 2008 09:03:40 -0200 From: "Carlos A. M. dos Santos" <unixmania@gmail.com> To: obrien@freebsd.org, freebsd-current@freebsd.org Subject: Re: Shooting sysinstall/SADE geometry warning in the head Message-ID: <e71790db0812260303i5e22397bq24ab010d5311031c@mail.gmail.com> In-Reply-To: <20081226072712.GA25406@dragon.NUXI.org> References: <20081226072712.GA25406@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_83359_7171511.1230289420814
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
On Fri, Dec 26, 2008 at 5:27 AM, David O'Brien <obrien@freebsd.org> wrote:
> It seems Sysinstall and SADE are ingorant of today's disk geometries.
> Is there good reason to not make this change? I've been getting the
> gratitious
>
> +----------------------------- Message -----------------------------+
> |WARNING: A geometry of 290721/16/63 for ad8 is incorrect. Using |
[...]
>
> warning from just about every usage of sysinstall/SADE over the past
> few years.
I suggested the attached patch some time ago. It keeps the message but
makes it less scaring. Please see
http://lists.freebsd.org/pipermail/freebsd-stable/2008-May/042697.html
--
cd /usr/ports/sysutils/life
make clean
------=_Part_83359_7171511.1230289420814
Content-Type: application/octet-stream; name=sysinstall-64kcyl.diff
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fp6q5u440
Content-Disposition: attachment; filename=sysinstall-64kcyl.diff
ZGlmZiAtZHVyUCBzeXNpbnN0YWxsLm9yaWcvZGlza3MuYyBzeXNpbnN0YWxsL2Rpc2tzLmMKLS0t
IHN5c2luc3RhbGwub3JpZy9kaXNrcy5jCTIwMDgtMDItMDEgMTg6Mjg6NDQuMDAwMDAwMDAwIC0w
MjAwCisrKyBzeXNpbnN0YWxsL2Rpc2tzLmMJMjAwOC0wNS0yNSAyMzo0MzozNi4wMDAwMDAwMDAg
LTAzMDAKQEAgLTEwNiw2ICsxMDYsNDcgQEAKIHN0YXRpYyBkYWRkcl90IFRvdGFsOwogCiBzdGF0
aWMgdm9pZAorY2hlY2tfZ2VvbWV0cnkoRGlzayAqZCkKK3sKKyAgICBpbnQgc2c7CisKKyNpZmRl
ZiBQQzk4CisgICAgaWYgKGQtPmJpb3NfY3lsID49IDY1NTM2IHx8IGQtPmJpb3NfaGQgPiAyNTYg
fHwgZC0+Ymlvc19zZWN0ID49IDI1NikKKyNlbHNlCisgICAgaWYgKGQtPmJpb3NfY3lsID4gNjU1
MzYgfHwgZC0+Ymlvc19oZCA+IDI1NiB8fCBkLT5iaW9zX3NlY3QgPj0gNjQpCisjZW5kaWYKKyAg
ICB7CisJZGlhbG9nX2NsZWFyX25vcmVmcmVzaCgpOworCXNnID0gbXNnWWVzTm8oIldBUk5JTkc6
ICBJdCBpcyBzYWZlIHRvIHVzZSBhIGdlb21ldHJ5IG9mICVsdS8lbHUvJWx1IGZvciAlcyBvblxu
IgorCQkgICAgICAiY29tcHV0ZXJzIHdpdGggbW9kZXJuIEJJT1MgdmVyc2lvbnMuICBJZiB0aGlz
IGRpc2sgaXMgdG8gYmUgdXNlZFxuIgorCQkgICAgICAib24gcmF0aGVyIG9sZCBtYWNoaW5lcywg
aG93ZXZlciwgaXQgaXMgcmVjb21tZW5kZWQgdG8gZW5zdXJlIHRoYXRcbiIKKwkJICAgICAgIml0
IGRvZXMgbm90IGhhdmUgbW9yZSB0aGFuIDY1NTM1IGN5bGluZGVycywgb3IgbW9yZSB0aGFuIDI1
NSBoZWFkc1xuIgorCQkgICAgICAib3IgbW9yZSB0aGFuICIKKyNpZmRlZiBQQzk4CisJCSAgICAg
ICIyNTUiCisjZWxzZQorCQkgICAgICAiNjMiCisjZW5kaWYKKwkJICAgICAgIiBzZWN0b3JzIHBl
ciB0cmFjay5cbiIKKwkJICAgICAgIlxuIgorCQkgICAgICAiV291bGQgeW91IGxpa2UgdGhhdCB0
byBrZWVwIHVzaW5nIHRoZSBjdXJyZW50IGdlb21ldHJ5P1xuIiwKKwkJICAgICAgZC0+Ymlvc19j
eWwsIGQtPmJpb3NfaGQsIGQtPmJpb3Nfc2VjdCwgZC0+bmFtZSk7CisJaWYgKHNnID09IDEpIHsK
KwkgICAgU2FuaXRpemVfQmlvc19HZW9tKGQpOworCSAgICBtc2dDb25maXJtKCJBIGdlb21ldHJ5
IG9mICVsdS8lbHUvJWx1IHdhcyBjYWxjdWxhdGVkIGZvciAlcy5cbiIKKwkJICAgICAgICJcbiIK
KwkJICAgICAgICJJZiB5b3UgYXJlIG5vdCBzdXJlIGFib3V0IHRoaXMsIHBsZWFzZSBjb25zdWx0
IHRoZSBIYXJkd2FyZSBHdWlkZVxuIgorCQkgICAgICAgImluIHRoZSBEb2N1bWVudGF0aW9uIHN1
Ym1lbnUgb3IgdXNlIHRoZSAoRyllb21ldHJ5IGNvbW1hbmQgdG9cbiIKKwkJICAgICAgICJjaGFu
Z2UgaXQuICBSZW1lbWJlcjogeW91IG5lZWQgdG8gZW50ZXIgd2hhdGV2ZXIgeW91ciBCSU9TIHRo
aW5rc1xuIgorCQkgICAgICAgInRoZSBnZW9tZXRyeSBpcyEgIEZvciBJREUsIGl0J3Mgd2hhdCB5
b3Ugd2VyZSB0b2xkIGluIHRoZSBCSU9TXG4iCisJCSAgICAgICAic2V0dXAuICBGb3IgU0NTSSwg
aXQncyB0aGUgdHJhbnNsYXRpb24gbW9kZSB5b3VyIGNvbnRyb2xsZXIgaXNcbiIKKwkJICAgICAg
ICJ1c2luZy4gIERvIE5PVCB1c2UgYSBgYHBoeXNpY2FsIGdlb21ldHJ5JycuXG4iLAorCQkgICAg
ICAgZC0+Ymlvc19jeWwsIGQtPmJpb3NfaGQsIGQtPmJpb3Nfc2VjdCwgZC0+bmFtZSk7CisJfQor
ICAgIH0KK30KKworc3RhdGljIHZvaWQKIHByaW50X2NodW5rcyhEaXNrICpkLCBpbnQgdSkKIHsK
ICAgICBpbnQgcm93OwpAQCAtMTE5LDI0ICsxNjAsNiBAQAogICAgIFRvdGFsID0gMDsKICAgICBm
b3IgKGkgPSAwOyBjaHVua19pbmZvW2ldOyBpKyspCiAJVG90YWwgKz0gY2h1bmtfaW5mb1tpXS0+
c2l6ZTsKLSNpZmRlZiBQQzk4Ci0gICAgaWYgKGQtPmJpb3NfY3lsID49IDY1NTM2IHx8IGQtPmJp
b3NfaGQgPiAyNTYgfHwgZC0+Ymlvc19zZWN0ID49IDI1NikgewotI2Vsc2UKLSAgICBpZiAoZC0+
Ymlvc19jeWwgPiA2NTUzNiB8fCBkLT5iaW9zX2hkID4gMjU2IHx8IGQtPmJpb3Nfc2VjdCA+PSA2
NCkgewotI2VuZGlmCi0JZGlhbG9nX2NsZWFyX25vcmVmcmVzaCgpOwotCW1zZ0NvbmZpcm0oIldB
Uk5JTkc6ICBBIGdlb21ldHJ5IG9mICVsdS8lbHUvJWx1IGZvciAlcyBpcyBpbmNvcnJlY3QuICBV
c2luZ1xuIgotCQkgICAiYSBtb3JlIGxpa2VseSBnZW9tZXRyeS4gIElmIHRoaXMgZ2VvbWV0cnkg
aXMgaW5jb3JyZWN0IG9yIHlvdVxuIgotCQkgICAiYXJlIHVuc3VyZSBhcyB0byB3aGV0aGVyIG9y
IG5vdCBpdCdzIGNvcnJlY3QsIHBsZWFzZSBjb25zdWx0XG4iCi0JCSAgICJ0aGUgSGFyZHdhcmUg
R3VpZGUgaW4gdGhlIERvY3VtZW50YXRpb24gc3VibWVudSBvciB1c2UgdGhlXG4iCi0JCSAgICIo
Ryllb21ldHJ5IGNvbW1hbmQgdG8gY2hhbmdlIGl0IG5vdy5cblxuIgotCQkgICAiUmVtZW1iZXI6
IHlvdSBuZWVkIHRvIGVudGVyIHdoYXRldmVyIHlvdXIgQklPUyB0aGlua3MgdGhlXG4iCi0JCSAg
ICJnZW9tZXRyeSBpcyEgIEZvciBJREUsIGl0J3Mgd2hhdCB5b3Ugd2VyZSB0b2xkIGluIHRoZSBC
SU9TXG4iCi0JCSAgICJzZXR1cC4gRm9yIFNDU0ksIGl0J3MgdGhlIHRyYW5zbGF0aW9uIG1vZGUg
eW91ciBjb250cm9sbGVyIGlzXG4iCi0JCSAgICJ1c2luZy4gIERvIE5PVCB1c2UgYSBgYHBoeXNp
Y2FsIGdlb21ldHJ5JycuIiwKLQkgIGQtPmJpb3NfY3lsLCBkLT5iaW9zX2hkLCBkLT5iaW9zX3Nl
Y3QsIGQtPm5hbWUpOwotCVNhbml0aXplX0Jpb3NfR2VvbShkKTsKLSAgICB9CiAgICAgYXR0cnNl
dChBX05PUk1BTCk7CiAgICAgbXZhZGRzdHIoMCwgMCwgIkRpc2sgbmFtZTpcdCIpOwogICAgIGNs
cnRvYm90KCk7CkBAIC0zNDEsNiArMzY0LDkgQEAKICAgICAvKiBTZXQgdXAgdGhlIGNodW5rIGFy
cmF5ICovCiAgICAgcmVjb3JkX2NodW5rcyhkKTsKIAorICAgIC8qIEdpdmUgdGhlIHVzZXIgYSBj
aGFuY2UgdG8gc2FuaXRpemUgdGhlIGRpc2sgZ2VvbWV0cnksIGlmIG5lY2Vzc2FyeSAqLworICAg
IGNoZWNrX2dlb21ldHJ5KGQpOworCiAgICAgd2hpbGUgKGNodW5raW5nKSB7CiAJY2hhciAqdmFs
LCBnZW9tZXRyeVs4MF07CiAJICAgIApAQCAtOTE2LDIxICs5NDIsMjQgQEAKICAgICByZWNvcmRf
Y2h1bmtzKGQpOwogICAgIGNwID0gdmFyaWFibGVfZ2V0KFZBUl9HRU9NRVRSWSk7CiAgICAgaWYg
KGNwKSB7Ci0JbXNnRGVidWcoIlNldHRpbmcgZ2VvbWV0cnkgZnJvbSBzY3JpcHQgdG86ICVzXG4i
LCBjcCk7Ci0JZC0+Ymlvc19jeWwgPSBzdHJ0b2woY3AsICZjcCwgMCk7Ci0JZC0+Ymlvc19oZCA9
IHN0cnRvbChjcCArIDEsICZjcCwgMCk7Ci0JZC0+Ymlvc19zZWN0ID0gc3RydG9sKGNwICsgMSwg
MCwgMCk7Ci0gICAgfSBlbHNlIHsKKwlpZiAoIXN0cmNhc2VjbXAoY3AsICJzYW5lIikpIHsKICNp
ZmRlZiBQQzk4Ci0JaWYgKGQtPmJpb3NfY3lsID49IDY1NTM2IHx8IGQtPmJpb3NfaGQgPiAyNTYg
fHwgZC0+Ymlvc19zZWN0ID49IDI1NikgeworCSAgICBpZiAoZC0+Ymlvc19jeWwgPj0gNjU1MzYg
fHwgZC0+Ymlvc19oZCA+IDI1NiB8fCBkLT5iaW9zX3NlY3QgPj0gMjU2KQogI2Vsc2UKLQlpZiAo
ZC0+Ymlvc19jeWwgPiA2NTUzNiB8fCBkLT5iaW9zX2hkID4gMjU2IHx8IGQtPmJpb3Nfc2VjdCA+
PSA2NCkgeworCSAgICBpZiAoZC0+Ymlvc19jeWwgPiA2NTUzNiB8fCBkLT5iaW9zX2hkID4gMjU2
IHx8IGQtPmJpb3Nfc2VjdCA+PSA2NCkKICNlbmRpZgotCSAgICBtc2dEZWJ1ZygiV2FybmluZzog
IEEgZ2VvbWV0cnkgb2YgJWx1LyVsdS8lbHUgZm9yICVzIGlzIGluY29ycmVjdC5cbiIsCi0JCWQt
PmJpb3NfY3lsLCBkLT5iaW9zX2hkLCBkLT5iaW9zX3NlY3QsIGQtPm5hbWUpOwotCSAgICBTYW5p
dGl6ZV9CaW9zX0dlb20oZCk7Ci0JICAgIG1zZ0RlYnVnKCJTYW5pdGl6ZWQgZ2VvbWV0cnkgZm9y
ICVzIGlzICVsdS8lbHUvJWx1LlxuIiwKLQkJZC0+bmFtZSwgZC0+Ymlvc19jeWwsIGQtPmJpb3Nf
aGQsIGQtPmJpb3Nfc2VjdCk7CisJICAgIHsKKwkJbXNnRGVidWcoIldhcm5pbmc6ICBBIGdlb21l
dHJ5IG9mICVsdS8lbHUvJWx1IGZvciAlcyBpcyBpbmNvcnJlY3QuXG4iLAorCQkgICAgZC0+Ymlv
c19jeWwsIGQtPmJpb3NfaGQsIGQtPmJpb3Nfc2VjdCwgZC0+bmFtZSk7CisJCVNhbml0aXplX0Jp
b3NfR2VvbShkKTsKKwkJbXNnRGVidWcoIlNhbml0aXplZCBnZW9tZXRyeSBmb3IgJXMgaXMgJWx1
LyVsdS8lbHUuXG4iLAorCQkgICAgZC0+bmFtZSwgZC0+Ymlvc19jeWwsIGQtPmJpb3NfaGQsIGQt
PmJpb3Nfc2VjdCk7CisJICAgIH0KKwl9IGVsc2UgeworCSAgICBtc2dEZWJ1ZygiU2V0dGluZyBn
ZW9tZXRyeSBmcm9tIHNjcmlwdCB0bzogJXNcbiIsIGNwKTsKKwkgICAgZC0+Ymlvc19jeWwgPSBz
dHJ0b2woY3AsICZjcCwgMCk7CisJICAgIGQtPmJpb3NfaGQgPSBzdHJ0b2woY3AgKyAxLCAmY3As
IDApOworCSAgICBkLT5iaW9zX3NlY3QgPSBzdHJ0b2woY3AgKyAxLCAwLCAwKTsKIAl9CiAgICAg
fQogCmRpZmYgLWR1clAgc3lzaW5zdGFsbC5vcmlnL3N5c2luc3RhbGwuOCBzeXNpbnN0YWxsL3N5
c2luc3RhbGwuOAotLS0gc3lzaW5zdGFsbC5vcmlnL3N5c2luc3RhbGwuOAkyMDA3LTA2LTI1IDEz
OjM3OjE2LjAwMDAwMDAwMCAtMDMwMAorKysgc3lzaW5zdGFsbC9zeXNpbnN0YWxsLjgJMjAwOC0w
NS0yMyAyMjo1MzoyOC4wMDAwMDAwMDAgLTAzMDAKQEAgLTI0OSw2ICsyNDksMTIgQEAKIC5CbCAt
dGFnIC13aWR0aCBmaW5keAogLkl0IGdlb21ldHJ5CiBUaGUgZGlzayBnZW9tZXRyeSwgYXMgYSBj
eWxzL2hlYWRzL3NlY3RvcnMgZm9ybWF0dGVkIHN0cmluZy4KK1RoZSB3b3JkICJzYW5lIiBpbnN0
cnVjdHMKKy5ObQordG8gY2FsY3VsYXRlIGEgc2FmZSAobm90IG5lY2Vzc2FyaWx5IG9wdGltYWwp
IGdlb21ldHJ5IGlmIHRoZQorY3VycmVudCBvbmUgaGFzIG1vcmUgdGhhbiA2NTUzNSBjeWxpbmRl
cnMsIG1vcmUgdGhhbiAyNTYgaGVhZHMgb3IKK21vcmUgdGhhbiA2MyBzZWN0b3JzIHBlciB0cmFj
ayAoMjU1IHNlY3RvcnMgb24gdGhlIFBDOTgKK2FyY2hpdGVjdHVyZSkuCiBEZWZhdWx0OiBubwog
Y2hhbmdlIHRvIGdlb21ldHJ5LgogLkl0IHBhcnRpdGlvbgo=
------=_Part_83359_7171511.1230289420814--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e71790db0812260303i5e22397bq24ab010d5311031c>