Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 15 Apr 2024 08:11:33 +0300
From:      Matthias Fechner <mfechner@freebsd.org>
To:        Gleb Popov <arrowd@freebsd.org>
Cc:        "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org>
Subject:   Re: Package a second port (gitlab-ee instead of gitlab-ce)
Message-ID:  <edd764f3-2ff1-4461-a768-1fe6affdbc09@freebsd.org>
In-Reply-To: <CALH631mpCqdU2tX9iF1MYpPO1kjrTmbHcYtmajMgAZj8o-U%2BOA@mail.gmail.com>
References:  <58745d45-46f3-4152-bc30-eee0794fe55c@freebsd.org> <CALH631mDNYn0ieau5E4z8_tnQe%2BSGNbo-3mRfzKSirA=bWdO3w@mail.gmail.com> <0da7afa3-465f-4364-aad0-5b0932283b21@freebsd.org> <CALH631mpCqdU2tX9iF1MYpPO1kjrTmbHcYtmajMgAZj8o-U%2BOA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help 
This is a multi-part message in MIME format.
--------------Mx6JEZfFl1DVgeEbKL0qc5jA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Am 12.04.2024 um 19:47 schrieb Gleb Popov:
> The ${FLAVOR:U...} expression looks a bit weird to me. You have
> FLAVOR?= ... in your Makefile, so this var can't really be undefined


thanks a lot for your time having a look to it.
You are right, it has as default ce defined. I simplified it now with:
|.if ${FLAVOR:U} == ee|

|
|

> Yes, see man 8 poudriere, the FLAVORS section. When running poud bulk
> -a, all flavors are built. Otherwise, the behavior is controlled by
> FLAVOR_DEFAULT_ALL option in the poudriere.conf

thanks, I fixed it now by adding just the following two lines into my 
pkglist (as I do not build all ports on my local poudriere and I do not 
want to interfere with my other builds):
www/gitlab
www/gitlab@ee

I think I will make the Gitlab EE port available together with the next 
Gitlab 16.11 upgrade.
The current tests are looking nice and I think the flavor support for 
Gitlab is ready.

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook

--------------Mx6JEZfFl1DVgeEbKL0qc5jA
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Am 12.04.2024 um 19:47 schrieb Gleb
      Popov:<br>
    </div>
    <blockquote type="cite"
cite="mid:CALH631mpCqdU2tX9iF1MYpPO1kjrTmbHcYtmajMgAZj8o-U+OA@mail.gmail.com">
      <pre><pre class="moz-quote-pre" wrap="">The ${FLAVOR:U...} expression looks a bit weird to me. You have
FLAVOR?= ... in your Makefile, so this var can't really be undefined</pre></pre>
    </blockquote>
    <p><br>
    </p>
    <p>thanks a lot for your time having a look to it.<br>
      You are right, it has as default ce defined. I simplified it now
      with:<br>
      <code><span><span class="nl">.if ${FLAVOR</span><span class="o">:</span><span
            class="nf">U} == ee</span></span></code></p>
    <p><code><span><span class="nf"><br>
          </span></span>
      </code></p>
    <blockquote type="cite"
cite="mid:CALH631mpCqdU2tX9iF1MYpPO1kjrTmbHcYtmajMgAZj8o-U+OA@mail.gmail.com">
      <pre>Yes, see man 8 poudriere, the FLAVORS section. When running poud bulk<pre
      class="moz-quote-pre" wrap="">-a, all flavors are built. Otherwise, the behavior is controlled by
FLAVOR_DEFAULT_ALL option in the poudriere.conf</pre></pre>
    </blockquote>
    <p>thanks, I fixed it now by adding just the following two lines
      into my pkglist (as I do not build all ports on my local poudriere
      and I do not want to interfere with my other builds):<br>
      www/gitlab<br>
      www/gitlab@ee<br>
    </p>
    <p>I think I will make the Gitlab EE port available together with
      the next Gitlab 16.11 upgrade.<br>
      The current tests are looking nice and I think the flavor support
      for Gitlab is ready.<br>
    </p>
    <pre class="moz-signature" cols="72">
Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
</pre>
  </body>
</html>

--------------Mx6JEZfFl1DVgeEbKL0qc5jA--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?edd764f3-2ff1-4461-a768-1fe6affdbc09>