Date: Tue, 3 Jul 2018 12:02:56 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Niclas Zeising <zeising+freebsd@daemonic.se>, "O. Hartmann" <ohartmann@walstatt.org>, FreeBSD Current <freebsd-current@FreeBSD.org> Subject: Re: atomic changes break drm-next-kmod? Message-ID: <ee0f7fce-7ce3-3784-f9e8-0f6862d59303@FreeBSD.org> In-Reply-To: <cbd2d2f2-8ce4-871a-9aaf-75738d6c465b@daemonic.se> References: <c640afcd-1fa4-a43e-5f36-f0bd11aad63d@protected-networks.net> <20180703170223.266dbf5b@thor.intern.walstatt.dynvpn.de> <cbd2d2f2-8ce4-871a-9aaf-75738d6c465b@daemonic.se>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/3/18 11:28 AM, Niclas Zeising wrote: > On 07/03/18 17:02, O. Hartmann wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA512 >> >> Am Tue, 3 Jul 2018 10:19:57 -0400 >> Michael Butler <imb@protected-networks.net> schrieb: >> >>> It seems recent changes (SVN r335873?) may have broken drm-next-kmod .. >>> >>> --- i915_drv.o --- >>> In file included from i915_drv.c:30: >>> In file included from >>> /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/linuxkpi/gplv2/include/linux/acpi.h:26: >>> In file included from >>> /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/linuxkpi/gplv2/include/linux/device.h:4: >>> In file included from >>> /usr/src/sys/compat/linuxkpi/common/include/linux/device.h:35: >>> In file included from >>> /usr/src/sys/compat/linuxkpi/common/include/linux/types.h:37: >>> In file included from /usr/src/sys/sys/systm.h:44: >>> ./machine/atomic.h:450:29: error: invalid operand for instruction >>> ATOMIC_ASM(clear, long, "andq %1,%0", "ir", ~v); >>> ^ >>> <inline asm>:1:7: note: instantiated into assembly here >>> andq $9223372036854775807,40672(%r14) >>> ^~~~~~~~~~~~~~~~~~~~~ >>> 1 error generated. >>> *** [i915_drv.o] Error code 1 >>> >>> make[3]: stopped in >>> /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/i915 >>> --- i915_gem.o --- >>> In file included from i915_gem.c:28: >>> In file included from >>> /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/include/drm/drmP.h:38: >>> In file included from /usr/src/sys/sys/malloc.h:42: >>> In file included from /usr/src/sys/sys/systm.h:44: >>> ./machine/atomic.h:449:29: error: invalid operand for instruction >>> ATOMIC_ASM(set, long, "orq %1,%0", "ir", v); >>> ^ >>> <inline asm>:1:6: note: instantiated into assembly here >>> orq $-9223372036854775808,40672(%r14) >>> ^~~~~~~~~~~~~~~~~~~~~~ >>> 1 error generated. >>> *** [i915_gem.o] Error code 1 >>> >>> _______________________________________________ >>> freebsd-current@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-current >>> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >> >> >> It breaks also graphics/drm-stable-kmod (see PR 229484, >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229484, same error as you described >> above) and also emulators/virtualbox-ose-kmod. As long as CURRENT revision is < r335873, >> those kmod compile well. > > We are looking into why both the drm ports fail. > Regards > I haven't yet tested an amd64 kernel with this, but I think this change to sys/amd64/include/atomic.h might fix it: Index: atomic.h =================================================================== --- atomic.h (revision 335896) +++ atomic.h (working copy) @@ -446,10 +446,10 @@ ATOMIC_ASM(clear, int, "andl %1,%0", "ir", ~ ATOMIC_ASM(add, int, "addl %1,%0", "ir", v); ATOMIC_ASM(subtract, int, "subl %1,%0", "ir", v); -ATOMIC_ASM(set, long, "orq %1,%0", "ir", v); -ATOMIC_ASM(clear, long, "andq %1,%0", "ir", ~v); -ATOMIC_ASM(add, long, "addq %1,%0", "ir", v); -ATOMIC_ASM(subtract, long, "subq %1,%0", "ir", v); +ATOMIC_ASM(set, long, "orq %1,%0", "er", v); +ATOMIC_ASM(clear, long, "andq %1,%0", "er", ~v); +ATOMIC_ASM(add, long, "addq %1,%0", "er", v); +ATOMIC_ASM(subtract, long, "subq %1,%0", "er", v); #define ATOMIC_LOADSTORE(TYPE) \ ATOMIC_LOAD(TYPE); \ -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ee0f7fce-7ce3-3784-f9e8-0f6862d59303>