Date: Tue, 30 Dec 2008 19:57:03 +0100 From: "Torfinn Ingolfsen" <tingox@gmail.com> To: freebsd-ports@freebsd.org Subject: Re: amule 2.2.3 port - first try Message-ID: <ef8c8a880812301057u79442721y58e61dd2cbdef99c@mail.gmail.com> In-Reply-To: <20081230183321.GD81218@hades.panopticon> References: <ef8c8a880812291539h1eea43a6x66b9a7ee5928a4fe@mail.gmail.com> <loom.20081230T101202-815@post.gmane.org> <ef8c8a880812301004y58dd743dy67fe7d9134c5a904@mail.gmail.com> <20081230183321.GD81218@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 30, 2008 at 7:33 PM, Dmitry Marakasov <amdmi3@amdmi3.ru> wrote: > Something tells me that he meant to answer your previous message > about a patch that removes a file. I thought you're trying to make a > patch-* for ports's files/ too, before I understood that you're trying to > make a patch to a port itself. I see. I'm sorry if I have confused anyone, it wasn't intentional. > This patch looks good at a first glance, I've scheduled it to be build > in a tinderbox. Which reminds me I have to fix my own tinderbox, after the last update it doesn't run anymore. Probably just ome config files that mut be changed. BTW, do I need to run tinderd to mae the web ui work? I can't remember how it worked when it worked. :) > Btw, I'll second porttools advice, it really does much work for you, > such as patch creation and partially filling send-pr form. Sounds great, I will install it next. > Also look at portlint - it inspects a port and porints you at some > common errors. Yes, portlint says: root@kg-v2# portlint amule2 WARN: Makefile: [17]: use tab (not space) to make indentation WARN: Conflict "ed2k-hash-*" specified too broad. You should end it with a version number fragment (-[0-9]*). 0 fatal errors and 2 warnings found. root@kg-v2# portlint -a amule2 WARN: Makefile: [17]: use tab (not space) to make indentation WARN: Conflict "ed2k-hash-*" specified too broad. You should end it with a version number fragment (-[0-9]*). WARN: Makefile: manpage for chapter 1 should be listed in MAN1, even if compression is not necessary. WARN: Makefile: how about using MANLANG for designating manual language, such as "fr"? 0 fatal errors and 4 warnings found. After changing the first two reported problems, portlint now reports this: root@kg-v2# portlint amule2 looks fine. root@kg-v2# portlint -a amule2 WARN: Makefile: manpage for chapter 1 should be listed in MAN1, even if compression is not necessary. WARN: Makefile: how about using MANLANG for designating manual language, such as "fr"? 0 fatal errors and 2 warnings found. I'll work more on the port. -- Regards, Torfinn Ingolfsen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ef8c8a880812301057u79442721y58e61dd2cbdef99c>