Date: Tue, 10 Jun 2008 13:13:00 -0500 From: "Jeremy Messenger" <mezz7@cox.net> To: "Kris Kennaway" <kris@freebsd.org> Cc: ports@freebsd.org Subject: Re: INDEX build optimizations - please review Message-ID: <op.ucjovyxo9aq2h7@mezz.mezzweb.com> In-Reply-To: <484EAFAC.3020208@FreeBSD.org> References: <484EAFAC.3020208@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 10 Jun 2008 11:45:32 -0500, Kris Kennaway <kris@FreeBSD.org> wro=
te:
> Another important optimization is to use /rescue/sh instead of /bin/sh=
=
> for index builds. The former is statically linked and this is much =
> faster to execute.
I don't have INDEX in all of my systems, so I am only take a peek. What =
=
about users that have WITHOUT_RESCUE defined or/and something different?=
=
IMO, I think your patch should have a check on if /rescue/sh exists when=
=
our src provides optional of WITHOUT_RESCUE and is harmless to kill the =
=
/rescue.
------------------------------
.if exists(/rescue/sh)
__MAKE_SHELL=3D/rescue/sh
.else
__MAKE_SHELL=3D/bin/sh
.endif
------------------------------
Thanks for hint on 'NOTE TO PORT DEVELOPERS' part as I didn't know about=
=
VARIABLE!=3D vs $(${VARIABLE_CMDS}). /me copies it in my note.
--
As for the audio/festvox-hvs issue, probably because of no executables o=
r =
files in RUN_DEPENDS:
------------------------------
RUN_DEPENDS=3D ${PORTSDIR}/audio/festival+OGI \
${PORTSDIR}/audio/festlex-poslex \
${PORTSDIR}/audio/festlex-ogi \
${PORTSDIR}/audio/festogi-spanish
------------------------------
Cheers,
Mezz
-- =
mezz7@cox.net - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.ucjovyxo9aq2h7>