Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Sep 2008 14:16:35 -0500
From:      "Jeremy Messenger" <mezz7@cox.net>
To:        "Alexey Shuvaev" <shuvaev@physik.uni-wuerzburg.de>
Cc:        freebsd-ports@freebsd.org
Subject:   Re: x11-wm/fluxbox fluxbox-generate_menu lists all available programs.
Message-ID:  <op.uhwc5x179aq2h7@mezz.mezzweb.com>
In-Reply-To: <20080922175249.GA43367@wep4035.physik.uni-wuerzburg.de>
References:  <20080922175249.GA43367@wep4035.physik.uni-wuerzburg.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Sep 2008 12:52:49 -0500, Alexey Shuvaev  
<shuvaev@physik.uni-wuerzburg.de> wrote:

> Hello!
>
> The script fluxbox-generate_menu shipped with current versions of
> fluxbox (fluxbox-1.1.0.1_1 and 1.1.1 too, I think) produces
> menu with all known programs. The reason for it is find_it* family
> of functions used to determine if the program exists (see attached  
> test.sh).
> It expects that 'hash' will return non-zero exit code when it cannot find
> the command and it is true on linix (some Ubuntu with 'dash',  
> surprisingly
> enough, man says it is BSD sh), but not here:
>
> ~> uname -a
> FreeBSD wep4035.physik.uni-wuerzburg.de 8.0-CURRENT FreeBSD 8.0-CURRENT  
> #0: Sun Sep 21 18:51:53 CEST 2008      
> root@wep4035.physik.uni-wuerzburg.de:/usr/obj/usr/src/sys/GENERIC  amd64
>
> ~> ./test.sh ls
> Found ls
>
> ~> ./test.sh bla-bla-non-existent
> Found bla-bla-non-existent
>
> Substituting 'hash' with 'which' solves the problem more or less,
> but I am not a sh guru to claim it is 100% correct.

I agree for 'which' is best thing to do. Not all shells (csh, see in  
builtin(1)) have 'hash' stuff. I have bring all of hash -> which stuff  
 from 1.0.0, so let me know patches work for you.

http://people.freebsd.org/~mezz/diff/patch-util%3a%3afluxbox-generate_menu.in
http://people.freebsd.org/~mezz/diff/patch-util_fbsetbg

Put those files in x11-wm/fluxbox/files/ and reinstall fluxbox.

> It could be also a sh(1) bug...

No idea, I get same result with zsh.

Cheers,
Mezz

> Alexey.


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.uhwc5x179aq2h7>