Date: Sun, 08 Nov 2009 03:19:05 +0100 (CET) From: Alexander Best <alexbestms@math.uni-muenster.de> To: <freebsd-hackers@freebsd.org> Cc: Alan Cox <alc@cs.rice.edu> Subject: mmap(2) with MAP_ANON honouring offset although it shouldn't Message-ID: <permail-20091108021905f0889e8400001ff7-a_best01@message-id.uni-muenster.de>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
no problem. i've sent the final patch as followup to kern/71258 and also
attached it to this message. to make it short. what's being changed by the
patch:
1) if MAP_ANON is defined and offset !=0 ====> return EINVAL
2) if MAP_STACK is defined and offset !=0 ====> offset = 0
would be great if you could have a look at the patch if you've got a spare
minute.
cheers.
alex
[-- Attachment #2 --]
Index: sys/vm/vm_mmap.c
===================================================================
--- sys/vm/vm_mmap.c (revision 199016)
+++ sys/vm/vm_mmap.c (working copy)
@@ -244,6 +244,9 @@
pos = 0;
}
+ if (flags & MAP_ANON && pos != 0)
+ return (EINVAL);
+
/*
* Align the file position to a page boundary,
* and save its page offset component.
@@ -300,7 +303,6 @@
handle = NULL;
handle_type = OBJT_DEFAULT;
maxprot = VM_PROT_ALL;
- pos = 0;
} else {
/*
* Mapping file, get fp for validation and
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-20091108021905f0889e8400001ff7-a_best01>