Date: Sun, 14 Mar 2010 13:12:14 +0100 (CET) From: Alexander Best <alexbestms@wwu.de> To: Garrett Cooper <yanefbsd@gmail.com> Cc: freebsd-hackers@freebsd.org, Doug Barton <dougb@freebsd.org> Subject: Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c Message-ID: <permail-2010031412121480e26a0b00003ff3-a_best01@message-id.uni-muenster.de> In-Reply-To: <7d6fde3d1003132155t3059a438m80bd50fdf1dbe091@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Garrett Cooper schrieb am 2010-03-14: > On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton <dougb@freebsd.org> > wrote: > > On 03/13/10 05:52, Alexander Best wrote: > >> hello, > >> this patch fixes the following gcc warning: > > For all such issues, please file a PR first so it doesn't get lost. > > When > > you get the PR confirmation back, feel free to alert the list to > > its > > existence. > Yes, please submit a proper PR for this because it's a code bug; > FYI, your solution isn't complete though (it's close): ah ok. thanks for the hint. just wanted to spare linimon from dealing with such minor prs. ;) > ABORT(3) FreeBSD Library Functions Manual > ABORT(3) > NAME > abort -- cause abnormal program termination > LIBRARY > Standard C Library (libc, -lc) > SYNOPSIS > #include <stdlib.h> > void > abort(void); > Please be explicit and add stdlib.h. adding stdlib.h isn't going to work since stand.h is used to declare function prototypes which are also in stdlib.h. adding stdlib.h will cause gcc to complain about multiple definitions. stand.h e.g. has it's own printf and some other stuff. cheers. alex > Thanks, > -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-2010031412121480e26a0b00003ff3-a_best01>