Date: Mon, 30 Oct 2000 15:38:31 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: "Steve O'Hara-Smith" <steveo@eircom.net>, stable@FreeBSD.ORG Subject: Re: Small patch to lpr - comments, review, commit ? Message-ID: <v04210101b6238abc898b@[128.113.24.47]> In-Reply-To: <20001030123305.23573c0e.steveo@eircom.net> References: <20001030123305.23573c0e.steveo@eircom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
At 12:33 PM +0000 10/30/00, Steve O'Hara-Smith wrote: > I have found that lpr does not pass the -C parameters to >lpd unless burst header pages are being printed. Unfortunately >apsfilter (ab)uses the -C parameters for printer mode control. >The patch below moves pass through of the -C parameters out of >the conditional block. As far as I can see this is never harmful. I suspect it is never harmful within our lpr. Not sure about how lprNG or various other things would treat it. My guess is it should never be harmful. In fact, I'm inclined to say both the 'C' and 'P' lines should be moved out of that conditional block. The only thing that really triggers a header sheet is the 'L' line, and there are other processes which might want that 'P' line to be there even if the header sheet is off. I could put that change into lpr in -current, if you want. It should probably sit there for a little while just to make sure it doesn't cause any problems when sent to other lpr implementations. (which is to say, this will not make 4.2-release...) --- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?v04210101b6238abc898b>