Date: Fri, 30 May 2003 18:00:22 +0800 From: "David Xu" <davidxu@freebsd.org> To: "Terry Lambert" <tlambert2@mindspring.com> Cc: freebsd-current@freebsd.org Subject: Re: panic: kern/52718 Message-ID: <003501c32692$4ae2e3d0$f001a8c0@davidw2k> References: <20030529164240.X769@gravy.homeunix.net><3ED71E39.A0F8EBC3@mindspring.com> <000701c3268b$86faaa30$f001a8c0@davidw2k> <3ED723FF.CBF45577@mindspring.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message -----=20 From: "Terry Lambert" <tlambert2@mindspring.com> To: "David Xu" <davidxu@freebsd.org> Cc: "Bryan Liesner" <bleez@verizon.net>; <freebsd-current@freebsd.org> Sent: Friday, May 30, 2003 5:27 PM Subject: Re: panic: kern/52718 > David Xu wrote: > > > This was caused by rev. 1.3 of a commit by Jeff Robertson to > > > kern_utmx.c. The problem is that the proc struct is not locked > > > for: > > > > > > FOREACH_THREAD_IN_PROC(td->td_proc, td0) > > > > > > in the lock and unlock. > > > > > > Either lock the proc before and unlock it after this, in both > > > _utmx_lock() and _utmx_unlock(), or revert the code to 1.2. > >=20 > > kern_sig.c has same issue in several places. >=20 > Just looked... YUCK! The Process group code and the code in > the filt_sigdetach() have got to be what you are talking about, > right? >=20 Yes. :( > I'm constantly surprised at some of the race windows I find in > production code (not just FreeBSD), that are just waiting there > to chew someone's leg off the first chance they get... 8-(. >=20 Welcome to fix it. > -- Terry > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?003501c32692$4ae2e3d0$f001a8c0>