Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Apr 1995 20:46:51 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        freebsd-current@freefall.cdrom.com, kuku@gilberto.physik.rwth-aachen.de
Cc:        ache@FreeBSD.org
Subject:   Re: world build on blues Sat Apr 29 18:15:00 MET DST 1995 (fwd)
Message-ID:  <199504301046.UAA22688@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>> /usr/src/lkm/ibcs2/../../sys/i386/ibcs2/ibcs2_file.c: In function `ibcs2_close':
>> /usr/src/lkm/ibcs2/../../sys/i386/ibcs2/ibcs2_file.c:66: warning: passing arg 2 of `close' from incompatible pointer type

>> /usr/src/lkm/ibcs2/../../sys/i386/ibcs2/ibcs2_ioctl.c: In function `ibcs2_ioctl':
>> /usr/src/lkm/ibcs2/../../sys/i386/ibcs2/ibcs2_ioctl.c:550: warning: `error' might be used uninitialized in this function

These may be old problems.

>> /usr/src/lkm/ibcs2/../../sys/i386/ibcs2/ibcs2_isc.c: In function `ibcs2_cisc':
>> /usr/src/lkm/ibcs2/../../sys/i386/ibcs2/ibcs2_isc.c:126: parse error before `)'

It's amazing how code can rot without even being changed. In this case,
the code was already broken, but hidden by an ifdef.  _POSIX_SAVED_IDS
doesn't necessarily have a value.  It is now defined and doesn't have a
value.

There are related bugs nearby:

1) _POSIX_JOB_CONTROL doesn't necessarily have a value either, and doesn't
   have one in FreeBSD, but the problem is hidden by a typo in the ifdef
   (_POSIX_JOB_CONTORL).
2) -1 is supposed to be returned if the functionality implied by these
   macros being defined is not supported.  0 is actually returned.  0
   means the same as 1 (the functionality is supported).

There are related bugs elsewhere:

3) kern_sysctl() has the same bug as in (2).

Apparently nothing actually uses sysconf(_SC_SAVED_IDS).  It has always
reported that FreeBSD-2.x has saved ids.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199504301046.UAA22688>