Date: Mon, 21 Oct 1996 15:48:15 -0700 From: skynyrd@opus.cts.cwu.edu To: FreeBSD-gnats-submit@freebsd.org Subject: kern/1859: fddi_input() floods system msg buffer when dropping noproto frames Message-ID: <199610212248.PAA07724@opus.cts.cwu.edu> Resent-Message-ID: <199610212250.PAA19650@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 1859
>Category: kern
>Synopsis: fddi_input() floods system msg buffer when dropping noproto frames
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Oct 21 15:50:01 PDT 1996
>Last-Modified:
>Originator: Chris Timmons
>Organization:
Central Washington University
>Release: FreeBSD 2.1.5-RELEASE; 2.2-CURRENT
>Environment:
DEFPA-DA adapter connected to ring where all sorts of non-IP protocols
are present.
Source module src/sys/net/if_fddisubr.c
>Description:
Unlike ether_input() which silently discards frames which it does not
queue for higher-layer processing, fddi_input() writes an informational
message, once per packet. The messages wind up in the system message
buffer as viewed by dmesg(8). Other messages are ultimately obscured.
(Try working on the console with the default syslog.conf in effect at this
time, too :)
I can't think of a reason (other than debugging) why we would want to leave
these printf's in the default code.
>How-To-Repeat:
ifconfig fpa0 n.n.n.n netmask m.m.m.m up
dmesg
>Fix:
patch against -CURRENT $Id: if_fddisubr.c,v 1.9 1996/06/10 23:07:31 gpalmer Exp $
*** if_fddisubr.c.OLD Mon Jun 10 16:07:31 1996
--- if_fddisubr.c Mon Oct 21 15:15:07 1996
***************
*** 445,451 ****
break;
#endif
default:
- printf("fddi_input: unknown protocol 0x%x\n", fddi_type);
ifp->if_noproto++;
goto dropanyway;
}
--- 445,450 ----
***************
*** 538,544 ****
#endif /* LLC */
default:
- printf("fddi_input: unknown dsap 0x%x\n", l->llc_dsap);
ifp->if_noproto++;
dropanyway:
m_freem(m);
--- 537,542 ----
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610212248.PAA07724>