Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Jun 1997 18:13:34 +0900 (JST)
From:      itojun@itojun.org
To:        FreeBSD-gnats-submit@FreeBSD.ORG
Subject:   ports/3888: port net/wu-ftpd: tiny bug that is wu-ftpd origin
Message-ID:  <199706170913.SAA01148@fennel.csl.sony.co.jp>
Resent-Message-ID: <199706170920.CAA05208@hub.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         3888
>Category:       ports
>Synopsis:       port net/wu-ftpd: tiny bug that is wu-ftpd origin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 17 02:20:00 PDT 1997
>Last-Modified:
>Originator:     Jun-ichiro ITOH
>Organization:
Sony CSL Inc., Tokyo, Japan
>Release:        FreeBSD 2.2-RELEASE i386
>Environment:

FreeBSD fennel.csl.sony.co.jp 2.2-RELEASE FreeBSD 2.2-RELEASE #8: Tue Jun 17 17:00:28 JST 1997     itojun@fennel.csl.sony.co.jp:/usr/src/sys.22RELEASE-PAO-ipsec/compile/FENNEL  i386

>Description:

	I found a tiny bug in wu-ftpd, so would like to
supply an patch for that (reported to wu-ftpd maintainer)

>How-To-Repeat:

	try to ftp by using account that has shells not listed in /etc/shells.

>Fix:
	
	very trivial.

--- patches/patch-ad-	Fri Jan 31 02:00:46 1997
+++ patches/patch-ad	Tue Jun 17 18:11:31 1997
@@ -1,5 +1,5 @@
-*** src/ftpd.c.bak	Mon Jan 20 08:05:11 1997
---- src/ftpd.c	Thu Jan 30 17:46:16 1997
+*** src/ftpd.c.orig	Mon Jan 20 14:05:11 1997
+--- src/ftpd.c	Tue Jun 17 17:55:14 1997
 ***************
 *** 235,246 ****
   int logging = 0;
@@ -15,6 +15,23 @@
   #define SecureWare
   #include <prot.h>
 --- 235,240 ----
+***************
+*** 1178,1184 ****
+                  break;
+          endusershell();
+          if (cp == NULL || checkuser(name)) {
+!             reply(530, "User %s access denied...(%s)", name);
+  /*            if (logging)	-- inconsistent, removed.  _H*/
+                  syslog(LOG_NOTICE,
+                         "FTP LOGIN REFUSED (bad shell) FROM %s [%s], %s",
+--- 1172,1178 ----
+                  break;
+          endusershell();
+          if (cp == NULL || checkuser(name)) {
+!             reply(530, "User %s access denied...", name);
+  /*            if (logging)	-- inconsistent, removed.  _H*/
+                  syslog(LOG_NOTICE,
+                         "FTP LOGIN REFUSED (bad shell) FROM %s [%s], %s",
 ***************
 *** 1201,1212 ****
               acl_setfunctions();
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199706170913.SAA01148>