Date: Sun, 18 Jun 2000 18:30:01 -0700 (PDT) From: Benno Rice <benno@netizen.com.au> To: freebsd-ports@FreeBSD.org Subject: Re: ports/19352: [PATCH] update textproc/sgmltools (v2.0.2) to sgmltools-lite v3.0.0 Message-ID: <200006190130.SAA07056@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/19352; it has been noted by GNATS.
From: Benno Rice <benno@netizen.com.au>
To: Will Andrews <andrews@technologist.com>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/19352: [PATCH] update textproc/sgmltools (v2.0.2) to sgmltools-lite v3.0.0
Date: Mon, 19 Jun 2000 11:21:13 +1000
On Sat, Jun 17, 2000 at 03:25:47PM -0400, Will Andrews wrote:
> On Sat, Jun 17, 2000 at 08:37:29PM +1000, benno@netizen.com.au wrote:
> > The included patch updates textproc/sgmltools to version 3.0.0, and
> > incorporates the name change to sgmltools-lite.
>
> Ok.. is there going to be a new sgmltools that's the "improved" version
> of this sgmltools-lite package? Or is sgmltools-lite a complete
> replacement?
Replacement as far as I can see. The difference between sgmltools and
sgmltools-lite is that before sgmltools included jade and a bunch of other
stuff. In the original port, I was pulling down sgmltools.base which is
pretty much what sgmltools-lite is now.
> > +MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}/sgmltools-lite/
>
> Did you actually try "make fetch" with this? :->
>
> In any case, when you use a MASTER_SITE, you need to use
> MASTER_SITE_SUBDIR, thus:
>
> MASTER_SITE_SUBDIR= sgmltools-lite
Ah, ok. =)
> > +INSTALL_PROGRAM=${INSTALL_SCRIPT}
>
> Uhh.. instead of doing this, why not just leave it alone and use
> ${INSTALL_SCRIPT} where necessary? In fact, I see nowhere in your
> update where ${INSTALL_PROGRAM} is used. :->
Check Makefile.in =)
Actually, I might have made that irrelevant with one of the patches.
Basically, the Makefile was being generated using INSTALL_PROGRAM to
install the sgmltools executable, which is a python script.
The -s flag that's in INSTALL_PROGRAM made life a bit difficult.
I think I ended up fixing it with a patch to the Makefile though, which
would make that line irrelevant.
--
Benno Rice "No, no. We're *sweet* and
XNFP Aries Dark Subculture- *innocent* evil bastards."
friendly Internet Geek
benno@netizen.com.au "Defend your joy"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006190130.SAA07056>