Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 May 2001 20:09:21 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Nick Sayer <nsayer@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/crypto/telnet/libtelnet pk.c
Message-ID:  <20010516200921.A15261@dragon.nuxi.com>
In-Reply-To: <200105161832.f4GIWkq20440@freefall.freebsd.org>; from nsayer@FreeBSD.org on Wed, May 16, 2001 at 11:32:46AM -0700
References:  <200105161832.f4GIWkq20440@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 16, 2001 at 11:32:46AM -0700, Nick Sayer wrote:
> nsayer      2001/05/16 11:32:46 PDT
> 
>   Modified files:
>     crypto/telnet/libtelnet pk.c 
>   Log:
>   srandomdev() affords us the opportunity to radically improve, and at the
>   same time simplify, the random number selection code.

There is _ZERO_ way you even tried to compile this C code (C rules are
different from C++...):


Index: pk.c
===================================================================
RCS file: /home/ncvs/src/crypto/telnet/libtelnet/pk.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -u -1 -r1.3 -r1.4
--- pk.c	2000/07/16 05:52:42	1.3
+++ pk.c	2001/05/16 18:32:46	1.4
@@ -1,3 +1,3 @@
 /* public key routines */
-/* $FreeBSD: src/crypto/telnet/libtelnet/pk.c,v 1.3 2000/07/16 05:52:42 peter Exp $ */
+/* $FreeBSD: src/crypto/telnet/libtelnet/pk.c,v 1.4 2001/05/16 18:32:46 nsayer Exp $ */
 /* functions:
@@ -119,2 +119,3 @@
 {
+#if 0
         int i,f;
@@ -142,2 +143,8 @@
         }
+#else
+	srandomdev();
+	for (i = 0; i < seedsize; i++) {
+		seed[i] = random() & 0xff;
+	}
+#endif
 }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010516200921.A15261>