Date: Tue, 10 Jul 2001 13:05:38 +0200 From: Johann Visagie <wjv@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.ORG> Cc: ports@FreeBSD.org, Neil Blakey-Milner <nbm@mithrandr.moria.org> Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <20010710130538.C97290@fling.sanbi.ac.za> In-Reply-To: <200107101031.f6AAV2J99898@vega.vega.com>; from sobomax@FreeBSD.ORG on Tue, Jul 10, 2001 at 01:31:01PM %2B0300 References: <20010710121638.A97290@fling.sanbi.ac.za> <200107101031.f6AAV2J99898@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev on 2001-07-10 (Tue) at 13:31:01 +0300:
>
> > Maxim Sobolev on 2001-07-10 (Tue) at 00:50:18 -0700:
> > >
> > > sobomax 2001/07/10 00:50:18 PDT
> > >
> > > Modified files:
> > > Mk bsd.port.mk
> > > Log:
> > > Similarly to DOCSDIR add DATADIR?=${PREFIX}/share/${PORTNAME}. Also slightly
> > > expand comment for DOCSDIR, so it is immediately clear what its value is.
> > >
> > > Ignored by: obrien, portmgr
> >
> > If we're going this far, then how about something like:
> > EXAMPLEDIR?=${PREFIX}/share/examples/${PORTNAME}
> >
> > (I find myself replicating that one quite often as well.)
> >
> > Moreover, in all the above cases, would it not be advisable to name the
> > actual directory ${PKGNAMEPREFIX}${PORTNAME} instead of just ${PORTNAME}?
>
> I do not think it is a good idea, because IMO ${PKGNAMEPREFIX}${PORTNAME}
> is less frequent than just ${PORTNAME}.
You're probably right for ${DATADIR}, but for ${DOCSDIR} (and a possible
${EXAMPLEDIR} or similar) ${PKGNAMEPREFIX}${PORTSDIR} is IMHO warranted:
- In the case of p5-, py- and ruby- ports, ${PORTNAME} on its own is often
rather undescriptive. (E.g. the textproc/py-xml port's ${PORTNAME} is
merely "xml".)
- Excluding ${PKGNAMEPREFIX} might lead to quite a few conflicts, e.g. when
we have both a p5-libfoo and a py-libfoo (and probably also a port of
libfoo for which the above are wrappers). If we have to override
${DOCSDIR} for every port it won't be of too much use, and using
${PKGNAMEPREFIX}${PORTNAME} won't break ${DOCSDIR} for ports which don't
have a ${PKGNAMEPREFIX}, will it?
-- V
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010710130538.C97290>