Date: Tue, 12 Feb 2002 16:11:29 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Maxime Henrion <mux@sneakerz.org> Cc: freebsd-arch@freebsd.org, Brooks Davis <brooks@one-eyed-alien.net> Subject: Re: Patches to if_loop + the interface cloning framework Message-ID: <20020212161129.A29154@Odin.AC.HMC.Edu> In-Reply-To: <20020212180337.D25374@sneakerz.org>; from mux@sneakerz.org on Tue, Feb 12, 2002 at 06:03:37PM -0600 References: <20020212154828.A25374@sneakerz.org> <20020212143909.B24768@Odin.AC.HMC.Edu> <20020212165544.B25374@sneakerz.org> <20020212153609.D24768@Odin.AC.HMC.Edu> <20020212174453.C25374@sneakerz.org> <20020212155646.A26408@Odin.AC.HMC.Edu> <20020212180337.D25374@sneakerz.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 12, 2002 at 06:03:37PM -0600, Maxime Henrion wrote: > Actually, after taking a closer look at it, there is no error checking > that can be done in locreate(). It calls if_attach() and bpfattach() > which are both void functions and calls malloc() with M_WAITOK. Were > you talking about something else ? Oops, you are correct. For some reasion I though M_WAITOK sometimes (rairly) failed, but according to the manpage I'm misremembering that flamewar. In that case, your origional code was correct in that the only way it can fail is if it already exists which isn't really a problem (though it's probably worth a KASSERT since it would represent a bug.) > What would it be useful to, if the kernel can't link without it ? The linking problem would be a fairly trivial fix. You would just have to move the definition elsewhere like I did with the external interfaces to faith(4). The underlying "specialness" of the loopback is another issue though and I'm not sure what the answer is. That doesn't mean there isn't one though and I don't see any reasion why we should go out of our way to remove support for the loopback device as a module. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8aa8wXY6L6fI4GtQRAlq+AKCZs/EtVNW9bzWNXS/1QRtyrwQEUQCg2NEH AEWXbw2aHrLlSYdWXQ2FORI= =koUv -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020212161129.A29154>