Date: Fri, 29 Mar 2002 20:25:33 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: winter@jurai.net, freebsd-current@FreeBSD.org Subject: Re: cvs commit: ports/lang Makefile ports/lang/icc Makefile distinfo pkg-comment pkg-descr pkg-plist ports/lang/icc/files patch-include Message-ID: <20020329202533.B74181@dragon.nuxi.com> In-Reply-To: <200203291044.g2TAi6h8000665@Magelan.Leidinger.net>; from Alexander@Leidinger.net on Fri, Mar 29, 2002 at 11:44:06AM %2B0100 References: <20020328181725.I45452-100000@sasami.jurai.net> <200203291044.g2TAi6h8000665@Magelan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 29, 2002 at 11:44:06AM +0100, Alexander Leidinger wrote: > > My patches to src/share/mk/ are here: > > > > ftp://ftp.jurai.net/users/winter/icc.mk.diff > > > > This allows you to set 'USE_ICC' and 'ICFLAGS' and build stuff. This is fine just to get things working. But please consider Doing It Right -- that being wrap the definitions of CC, CFLAGS, and PICFLAG with USE_ICC rather than strew USE_ICC all over the place. For instance: /usr/share/mk/sys.mk .if defined(USE_ICC) CC= icc .else CC= cc .endif > > -D__ICC__=1 > > ICC already defines '__ICC', doe we really need this? I see no reason for it. We should use the vendor's spelling for identifying their compiler. > > -D__attribute__(x)= > > -D__GNUC__=2 > > Ok as a short term solution, but IMHO this should get solved in the > source. Totally agreed for defining __GNUC__. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020329202533.B74181>