Date: Wed, 9 Mar 2005 17:44:22 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Jung-uk Kim <jkim@niksun.com> Cc: freebsd-amd64@FreeBSD.org Subject: Re: [PATCH] More stackgap removal Message-ID: <200503091744.22118.jhb@FreeBSD.org> In-Reply-To: <200503091656.32994.jkim@niksun.com> References: <200503021643.05580.jhb@FreeBSD.org> <200503091652.37031.jkim@niksun.com> <200503091656.32994.jkim@niksun.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 09 March 2005 04:56 pm, Jung-uk Kim wrote: > On Wednesday 09 March 2005 04:52 pm, Jung-uk Kim wrote: > > On Wednesday 09 March 2005 10:31 am, John Baldwin wrote: > > > On Wednesday 02 March 2005 04:43 pm, John Baldwin wrote: > > > > I've fixed up a few more syscalls to have kern_foo versions so > > > > that ABI wrappers for them can stop using the stackgap. In > > > > this patch, I've added kern_settimeofday() for ibcs2 and > > > > freebsd32, kern_adjtime() for freebsd32, and > > > > kern_sched_rr_get_interval() for Linux/i386 on amd64 (note that > > > > this means that COMPAT_LINUX32 now requires > > > > POSIX_PRIORITY_SCHEDULING). I've also added kern_readv() and > > > > kern_writev() for OSF/1, Linux/i386 on amd64, and freebsd32. > > > > For these functions I added a per-ABI version of copyinuio() to > > > > build a uio structure from the iovec array in userland. Testing > > > > and feedback of both native and compat binaries greatly > > > > appreciated. > > > > > > > > http://www.FreeBSD.org/~jhb/patches/abi.patch > > > > > > Is anyone willing to test this? > > > > I tested freebsd32. kern_settimeofday(), kern_adjtime(), and > > kern_readv() seemed okay. However, kern_writev() always fails with > > EBADF. Any idea? > > I am sorry to answer quickly to myself but I found a typo in the > patch. freebsd32_writev() calls kern_readv(). Oops. ;-) Doh, I noticed that when I did that in the other ABIs. :-P Thanks very much. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503091744.22118.jhb>