Date: Thu, 13 Oct 2005 18:18:58 +0200 (CEST) From: Zahemszky Gabor <gabor@zahemszky.hu> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/87374: incorrect use of WITH_THEORA vs. WITH_LIBTHEORA in some ports Message-ID: <200510131618.j9DGIwpA000784@zahemszky.hu> Resent-Message-ID: <200510131620.j9DGKH3c016319@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 87374
>Category: ports
>Synopsis: incorrect use of WITH_THEORA vs. WITH_LIBTHEORA in some ports
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Oct 13 16:20:17 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Zahemszky Gabor
>Release: FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD zahemszky.hu 5.4-STABLE FreeBSD 5.4-STABLE #0: Wed Sep 28 20:30:48 CEST 2005 root@Picasso.Zahemszky.HU:/usr/obj/usr/src/sys/PICASSO i386
>Description:
Many ports in the audio and multimedia categories (and maybe others) have
optional dependencies to special libraries (eg. libogg, libvorbis). It looks
like in the FreeBSD ports-tree, there isn't a correct way to tell the libtheora
dependency. Eg, in multimedia, there are libxine, vlc and vlc-devel, which use
the WITH_LIBTHEORA (or WITHOUT_LIBTHEORA) Makefile variable, but ffmpeg-devel,
mplayer and transcode use the WITH_THEORA (ot WITHOUT_THEORA) variables.
So if somebody'd like to include (exclude) libtheora, she has to define two
variables in /etc/make.conf: WITH_THEORA and WITH_LIBTHEORA (or w/o). It
would be better to use one; and after the other similar variable's name, I
think WITH_THEORA is the correct name.
>How-To-Repeat:
egrep -R 'WITH(OUT)?_(LIB)?THEORA' /usr/ports
>Fix:
In /usr/ports/multimedia/{libxine,vlc,vlc-devel}/Makefile, in the next (or
similar lines), change the WITH(OUT)?_LIBTHEORA strings to WITH(OUT)?_THEORA.
==
if !defined(WITHOUT_LIBTHEORA) && (exists(${LOCALBASE}/lib/libtheora.so.1) ||
defined (WITH_LIBTHEORA))
==
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510131618.j9DGIwpA000784>