Date: Wed, 21 Dec 2005 12:44:27 +0800 (CST) From: Yen-Ming Lee <leeym@utopia.leeym.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: vsevolod@FreeBSD.org, matthias.andree@gmx.de Subject: ports/90729: databases/db[0-9]*: check USE_BDB knob Message-ID: <20051221044427.E5CC3B29CE7@utopia.leeym.com> Resent-Message-ID: <200512210450.jBL4o4AM064250@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 90729
>Category: ports
>Synopsis: databases/db[0-9]*: check USE_BDB knob
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Dec 21 04:50:03 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Yen-Ming Lee
>Release: FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD utopia.leeym.com 6.0-STABLE FreeBSD 6.0-STABLE #0: Thu Nov 17 09:15:19 CST 2005 root@utopia.leeym.com:/usr/obj/usr/src/sys/UTOPIA i386
>Description:
- check USE_BDB in databases/db[0-9]*
without checking USE_BDB, it will become a infinite loop for package dependency
- the same problem for databases/postgresql[0-9]*, and I'll submit another PR later.
(Cc-ed to the maintainers of databases/db* and bsd.database.mk)
>How-To-Repeat:
# cd /usr/ports && make clean USE_BDB=blah
(yes, it causes the loop in any port for any value)
>Fix:
--- db.diff begins here ---
Index: db2/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/db2/Makefile,v
retrieving revision 1.37
diff -u -r1.37 Makefile
--- db2/Makefile 5 May 2004 19:43:50 -0000 1.37
+++ db2/Makefile 21 Dec 2005 04:28:01 -0000
@@ -18,6 +18,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
INSTALLS_SHLIB= yes
GNU_CONFIGURE= yes
CONFIGURE_SCRIPT= ../dist/configure
Index: db3/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/db3/Makefile,v
retrieving revision 1.61
diff -u -r1.61 Makefile
--- db3/Makefile 15 Nov 2005 06:48:16 -0000 1.61
+++ db3/Makefile 21 Dec 2005 04:28:01 -0000
@@ -23,6 +23,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
USE_REINPLACE= yes
INSTALLS_SHLIB= yes
USE_AUTOTOOLS= libtool:13
Index: db4/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/db4/Makefile,v
retrieving revision 1.55
diff -u -r1.55 Makefile
--- db4/Makefile 12 Apr 2005 03:25:00 -0000 1.55
+++ db4/Makefile 21 Dec 2005 04:28:01 -0000
@@ -19,6 +19,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
USE_REINPLACE= yes
GNU_CONFIGURE= yes
CONFIGURE_SCRIPT= ../dist/configure
Index: db41/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/db41/Makefile,v
retrieving revision 1.59
diff -u -r1.59 Makefile
--- db41/Makefile 13 Apr 2005 07:14:36 -0000 1.59
+++ db41/Makefile 21 Dec 2005 04:28:01 -0000
@@ -23,6 +23,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
USE_REINPLACE= yes
GNU_CONFIGURE= yes
CONFIGURE_SCRIPT= ../dist/configure
Index: db42/Makefile.db
===================================================================
RCS file: /home/pcvs/ports/databases/db42/Makefile.db,v
retrieving revision 1.8
diff -u -r1.8 Makefile.db
--- db42/Makefile.db 15 Nov 2005 06:48:16 -0000 1.8
+++ db42/Makefile.db 21 Dec 2005 04:28:01 -0000
@@ -7,6 +7,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
USE_REINPLACE= yes
INSTALLS_SHLIB= yes
USE_AUTOTOOLS= libtool:15
Index: db43/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/db43/Makefile,v
retrieving revision 1.71
diff -u -r1.71 Makefile
--- db43/Makefile 15 Nov 2005 06:48:16 -0000 1.71
+++ db43/Makefile 21 Dec 2005 04:28:01 -0000
@@ -21,6 +21,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
USE_REINPLACE= yes
INSTALLS_SHLIB= yes
USE_AUTOTOOLS= libtool:15
Index: db44/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/db44/Makefile,v
retrieving revision 1.72
diff -u -r1.72 Makefile
--- db44/Makefile 25 Nov 2005 20:45:27 -0000 1.72
+++ db44/Makefile 21 Dec 2005 04:28:01 -0000
@@ -21,6 +21,10 @@
WRKSRC= ${WRKDIR}/${DISTNAME}/build_unix
+.ifdef USE_BDB
+.error You have `USE_BDB' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
USE_REINPLACE= yes
INSTALLS_SHLIB= yes
USE_AUTOTOOLS= libtool:15
--- db.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051221044427.E5CC3B29CE7>