Date: Fri, 30 Nov 2007 16:40:58 GMT From: Alexander <fbsd@meersau.de> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/118355: pfctl help message options order false -t must before -T Message-ID: <200711301640.lAUGew8D039617@www.freebsd.org> Resent-Message-ID: <200711301650.lAUGo03J061544@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 118355 >Category: misc >Synopsis: pfctl help message options order false -t must before -T >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 30 16:50:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Alexander >Release: 5.5-STABLE >Organization: >Environment: FreeBSD gaspode.meersau.de 5.5-STABLE FreeBSD 5.5-STABLE #11: Sat Nov 24 14:09:04 CET 2007 root@gaspode.meersau.de:/usr/obj/usr/src/sys/GASPODE i386 >Description: If I try to add a entry in a pf table the option -T must follow -t so this command fails: % sudo pfctl -T add 86.51.7.205 -t badhosts No ALTQ support in kernel ALTQ related functions disabled usage: pfctl [-AdeghNnOqRrvz] [-a anchor[:ruleset]] [-D macro=value] [-F modifier] [-f file] [-i interface] [-k host] [-p device] [-s modifier] [-T command [address ...]] [-t table] [-x level] % The help message does display the -t option behind -T. I think it would be help to see the options in the right order. Also the order in the manpage is to be corrected, but I don't know the syntax. >How-To-Repeat: pfctl -T add 86.51.7.205 -t badhosts >Fix: --- pfctl.c Fri Nov 30 17:38:24 2007 +++ pfctl.c.orig Fri Nov 30 17:37:34 2007 @@ -202,8 +202,8 @@ fprintf(stderr, "[-F modifier] [-f file] [-i interface] "); fprintf(stderr, "[-k host] [-p device]\n"); fprintf(stderr, " "); - fprintf(stderr, "[-s modifier] [-t table] [-T command [address ...]] "); - fprintf(stderr, "[-x level]\n"); + fprintf(stderr, "[-s modifier] [-T command [address ...]] "); + fprintf(stderr, "[-t table] [-x level]\n"); exit(1); } >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200711301640.lAUGew8D039617>