Date: Sun, 31 Aug 2008 21:32:12 GMT From: Alexander Churanov <alexanderchuranov@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/127015: [patch] Impossible to fetch devel/valgrind from the jail Message-ID: <200808312132.m7VLWCwR053086@www.freebsd.org> Resent-Message-ID: <200808312140.m7VLe1YQ062690@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 127015
>Category: ports
>Synopsis: [patch] Impossible to fetch devel/valgrind from the jail
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun Aug 31 21:40:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Alexander Churanov
>Release: 6.2-RELEASE
>Organization:
N/A
>Environment:
FreeBSD jail 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Mar 24 09:45:45 MSK 2008 root@localhost:/usr/obj/usr/src/sys/HOMEBSD i386
>Description:
The "make fetch" in devel/valgrind refuses to download distfiles if running inside a jail. It complains about missing procfs. The procfs, however, is correctly working and accessible.
The issue was observed on FreeBSD 6.2 Release, using ports collection from August, 21 2008.
Expected behavior: presence of procfs is not verified when running targets like "fetch".
Acceptable behavior: actual presence of procfs is verified.
>How-To-Repeat:
1) Setup a jail with access to internet.
2) Uncompress "ports" collection into /usr/ports directory inside a jail.
3) Mount the "procfs" filesystem to /proc directory inside a jail from the host OS.
3) Start shell in the jail, cd into "devel/valgrind", type make fetch.
>Fix:
Modify the Makefile to verify that procfs is running and accessible instead of examining output of "/sbin/mount". See the suggested patch.
Patch attached with submission follows:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/valgrind/Makefile,v
retrieving revision 1.30
diff -U3 -r1.30 Makefile
--- Makefile 21 Aug 2008 06:16:52 -0000 1.30
+++ Makefile 25 Aug 2008 23:02:29 -0000
@@ -44,7 +44,7 @@
PLIST_SUB+= RELENG_7="@comment "
.endif
-PROCFS!= /sbin/mount | ${GREP} '^procfs' | ${AWK} '{print $1}'
+PROCFS!= if test -r /proc/curproc/status; then echo "procfs"; else echo ""; fi
pre-everything::
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808312132.m7VLWCwR053086>