Date: Wed, 22 Oct 2008 10:03:26 +0200 From: Ed Schouten <ed@80386.nl> To: current@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 Message-ID: <20081022080326.GH16837@hoeg.nl> In-Reply-To: <20081021210023.0CE4373039@freebsd-current.sentex.ca> References: <20081021210023.0CE4373039@freebsd-current.sentex.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--kIf/M4+cOKmnPkRL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
* FreeBSD Tinderbox <tinderbox@freebsd.org> wrote:
> cc1: warnings being treated as errors
> /src/sys/dev/ppbus/lpt.c: In function 'lpt_attach':
> /src/sys/dev/ppbus/lpt.c:402: warning: assignment makes pointer from inte=
ger without a cast
> /src/sys/dev/ppbus/lpt.c: In function 'lptopen':
> /src/sys/dev/ppbus/lpt.c:479: warning: assignment makes integer from poin=
ter without a cast
What about this?
%%%
--- sys/dev/ppbus/lpt.c
+++ sys/dev/ppbus/lpt.c
@@ -392,14 +392,12 @@
lpt_release_ppbus(dev);
=20
sc->dev =3D dev;
- sc->cdev =3D make_dev(&lpt_cdevsw, unit,
+ sc->cdev =3D make_dev(&lpt_cdevsw, 0,
UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d", unit);
sc->cdev->si_drv1 =3D sc;
- sc->cdev->si_drv2 =3D 0;
- sc->cdev_bypass =3D make_dev(&lpt_cdevsw, unit,
+ sc->cdev_bypass =3D make_dev(&lpt_cdevsw, LP_BYPASS,
UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d.ctl", unit);
sc->cdev_bypass->si_drv1 =3D sc;
- sc->cdev_bypass->si_drv2 =3D LP_BYPASS;
return (0);
}
=20
@@ -476,7 +474,7 @@
} else
sc->sc_state |=3D LPTINIT;
=20
- sc->sc_flags =3D dev->si_drv2;
+ sc->sc_flags =3D dev2unit(dev);
=20
/* Check for open with BYPASS flag set. */
if (sc->sc_flags & LP_BYPASS) {
%%%
--=20
Ed Schouten <ed@80386.nl>
WWW: http://80386.nl/
--kIf/M4+cOKmnPkRL
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkj+3k4ACgkQ52SDGA2eCwU42wCeNBJIEqHybsrX0mKoeQ9/ygRF
kVYAnRPo4cGRdo3gHXUQlxqcxc+s3DS1
=VmKF
-----END PGP SIGNATURE-----
--kIf/M4+cOKmnPkRL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081022080326.GH16837>