Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Feb 2009 17:45:04 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Marko Zec <zec@icir.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>, Julian Elischer <julian@freebsd.org>
Subject:   Re: PERFORCE change 157941 for review
Message-ID:  <20090219174342.S53478@maildrop.int.zabbadoz.net>
In-Reply-To: <200902191824.30353.zec@icir.org>
References:  <200902191710.n1JHAT4W092138@repoman.freebsd.org> <200902191824.30353.zec@icir.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 19 Feb 2009, Marko Zec wrote:

> On Thursday 19 February 2009 18:10:29 Julian Elischer wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=157941
>>
>> Change 157941 by julian@julian_trafmon1 on 2009/02/19 17:09:57
>>
>> 	Implement BZ's fix for altq to compile
>
> Thanks!
>
> Amazingly epair now really works with vimages!  Though, all cloned
> instances always have the same unit number (0)...

*huh* are you sure?

I'll get my test setup back online so ... and btw. it has worked with
vimage before but the ointegrated head had paniced in new-arp
somewhere;)

Things will be improved along the path I guess, netisr2 from rwatson,
proper testing ...



>> Affected files ...
>>
>> .. //depot/projects/vimage/src/sys/net/if_epair.c#5 edit
>>
>> Differences ...
>>
>> ==== //depot/projects/vimage/src/sys/net/if_epair.c#5 (text+ko) ====
>>
>> @@ -323,12 +323,12 @@
>>
>>  #ifdef ALTQ
>>  	/* Support ALTQ via the clasic if_start() path. */
>> -	IF_LOCK(&epairinq);
>> +	IF_LOCK(&ifp->if_snd);
>>  	if (ALTQ_IS_ENABLED(&ifp->if_snd)) {
>>  		ALTQ_ENQUEUE(&ifp->if_snd, m, NULL, error);
>>  		if (error)
>>  			ifp->if_snd.ifq_drops++;
>> -		IF_UNLOCK(&epairinq);
>> +		IF_UNLOCK(&ifp->if_snd);
>>  		if (!error) {
>>  			ifp->if_obytes += len;
>>  			if (mflags & (M_BCAST|M_MCAST))
>> @@ -341,7 +341,7 @@
>>  		}
>>  		return (error);
>>  	}
>> -	IF_UNLOCK(&epairinq);
>> +	IF_UNLOCK(&ifp->if_snd);
>>  #endif
>>
>>  	if ((epair_drv_flags & IFF_DRV_OACTIVE) != 0) {
>
>

-- 
Bjoern A. Zeeb                      The greatest risk is not taking one.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090219174342.S53478>