Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Apr 2010 10:26:04 GMT
From:      Ivan Klymenko <fidaj@ukr.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/145262: x11-wm/compiz update png_check_sig to !png_sig_cmp
Message-ID:  <201004011026.o31AQ4Ts092095@www.freebsd.org>
Resent-Message-ID: <201004011030.o31AU6K8057658@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         145262
>Category:       ports
>Synopsis:       x11-wm/compiz update png_check_sig to !png_sig_cmp
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 01 10:30:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Ivan Klymenko
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
individual
>Environment:
>Description:
The png library has been updated to version 1.4.1.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- plugins/png.c.orig	2010-04-01 13:17:02.000000000 +0300
+++ plugins/png.c	2010-04-01 13:17:34.000000000 +0300
@@ -167,7 +167,7 @@
     Bool	  status;
 
     sig_bytes = fread (png_sig, 1, PNG_SIG_SIZE, file);
-    if (png_check_sig (png_sig, sig_bytes) == 0)
+    if (!png_sig_cmp (png_sig, 1, sig_bytes) == 0)
 	return FALSE;
 
     png = png_create_read_struct (PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
@@ -218,7 +218,7 @@
     Bool		status;
 
     memcpy (png_sig, buffer, PNG_SIG_SIZE);
-    if (png_check_sig (png_sig, PNG_SIG_SIZE) == 0)
+    if (!png_sig_cmp (png_sig, 1, PNG_SIG_SIZE) == 0)
 	return FALSE;
 
     png = png_create_read_struct (PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004011026.o31AQ4Ts092095>