Date: Thu, 30 Sep 2010 10:03:26 GMT From: Youssef Ghorbal <djo@pasteur.fr> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/151108: [net-mgmt/pnp] png files broken because of dos2unix Message-ID: <201009301003.o8UA3Qge020144@www.freebsd.org> Resent-Message-ID: <201009301010.o8UAA2iu074498@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 151108 >Category: ports >Synopsis: [net-mgmt/pnp] png files broken because of dos2unix >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Sep 30 10:10:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Youssef Ghorbal >Release: FreeBSD 8.1 >Organization: Institut Pasteur >Environment: FreeBSD 8.1-RELEASE i386 >Description: png files shipped with the port (share/pnp/images/*.png) are broken because of dos2unix. A Dos to Unix conversion is launched on all files of the port when it has to be limited to .php only. $> pwd /usr/ports/net-mgmt/pnp $> make extract ===> Extracting for pnp-0.4.14_1 => MD5 Checksum OK for pnp-0.4.14.tar.gz. => SHA256 Checksum OK for pnp-0.4.14.tar.gz. $> file work/pnp-0.4.14/share/pnp/images/*.png [...] work/pnp-0.4.14/share/pnp/images/ack.png: PNG image, 16 x 16, 8-bit/color RGBA, non-interlaced [...] $> make patch ===> Patching for pnp-0.4.14_1 ===> Converting DOS text files to UNIX text files ===> Applying FreeBSD patches for pnp-0.4.14_1 $> file work/pnp-0.4.14/share/pnp/images/*.png [...] work/pnp-0.4.14/share/pnp/images/ack.png: data [...] >How-To-Repeat: just make patch in the ports directory >Fix: limit the dos2unix to only php files in the Makefile. Something like : DOS2UNIX_REGEX= .*\.php >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009301003.o8UA3Qge020144>