Date: Wed, 29 Jun 2011 23:06:40 GMT From: Géraud CONTINSOUZAS <geraud@gcu.info> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/158517: [PATCH] devel/p5-Devel-GlobalDestruction : PLIST differs based on the version of Perl Message-ID: <201106292306.p5TN6eA9040152@red.freebsd.org> Resent-Message-ID: <201106292310.p5TNA8Sb074879@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 158517 >Category: ports >Synopsis: [PATCH] devel/p5-Devel-GlobalDestruction : PLIST differs based on the version of Perl >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 29 23:10:07 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Géraud CONTINSOUZAS >Release: 8.2-STABLE >Organization: >Environment: FreeBSD kate.foo.local 8.2-STABLE FreeBSD 8.2-STABLE #0: Sun May 8 18:16:39 NCT 2011 >Description: Packaging this port with perl5.14 fails as some files listed in the plist are not installed. After looking at the changelog here : http://cpansearch.perl.org/src/FLORA/Devel-GlobalDestruction-0.03/Changes it is confirmed that XS files are not built for newer versions of perl (> 5.13.07) and therefore not installed, hence the failure during `make package`. The attached patch attempts to fix the problem, but I'd recommend a careful review from a commiter. >How-To-Repeat: cd /usr/ports/lang/perl5.14 && make && make install; cd /usr/ports/devel/p5-Devel-GlobalDestruction && make && make install && make package; >Fix: See attached patch. Patch attached with submission follows: --- Makefile.old 2010-12-03 17:38:57.000000000 +1100 +++ Makefile 2011-06-30 09:38:28.000000000 +1100 @@ -7,6 +7,7 @@ PORTNAME= Devel-GlobalDestruction PORTVERSION= 0.03 +PORTREVISION= 1 CATEGORIES= devel perl5 MASTER_SITES= CPAN PKGNAMEPREFIX= p5- @@ -22,4 +23,14 @@ MAN3= Devel::GlobalDestruction.3 -.include <bsd.port.mk> +.include <bsd.port.pre.mk> + +.if ${PERL_LEVEL} < 501400 +PLIST_SUB+= NEW_PERL_PLIST="@comment " +PLIST_SUB+= OLD_PERL_PLIST="" +.else +PLIST_SUB+= NEW_PERL_PLIST="" +PLIST_SUB+= OLD_PERL_PLIST="@comment " +.endif + +.include <bsd.port.post.mk> --- pkg-plist.old 2008-09-03 23:28:51.000000000 +1100 +++ pkg-plist 2011-06-30 09:36:00.000000000 +1100 @@ -1,8 +1,10 @@ -%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.bs -%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.so -%%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction.pm +%%OLD_PERL_PLIST%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.bs +%%OLD_PERL_PLIST%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.so +%%OLD_PERL_PLIST%%%%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction.pm +%%NEW_PERL_PLIST%%%%SITE_PERL%%/Devel/GlobalDestruction.pm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/.packlist @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel +@dirrmtry %%SITE_PERL%%/Devel >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106292306.p5TN6eA9040152>