Date: Sat, 11 Feb 2012 09:48:11 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Russell Cattelan <cattelan@thebarn.com> Cc: freebsd-amd64@freebsd.org Subject: Re: amd64/163710: setjump in userboot.so causes stack corruption Message-ID: <20120211074811.GR3283@deviant.kiev.zoral.com.ua> In-Reply-To: <201202110430.q1B4UGPe088047@freefall.freebsd.org> References: <201202110430.q1B4UGPe088047@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--32mFWuI8C7a/mRQ2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Feb 11, 2012 at 04:30:16AM +0000, Russell Cattelan wrote:
> The following reply was made to PR amd64/163710; it has been noted by GNA=
TS.
>=20
> From: Russell Cattelan <cattelan@thebarn.com>
> To: bug-followup@FreeBSD.org, cattelan@thebarn.com
> Cc: =20
> Subject: Re: amd64/163710: setjump in userboot.so causes stack corruption
> Date: Fri, 10 Feb 2012 22:04:52 -0600
>=20
> So here is a suggestion.
> =20
> So the default build does do the right thing.
> =20
> The problem is when doing userboot development the
> symlink from the loader build ends up including the wrong
> files.
> =20
> the userboot build of fill does not need a sym link so make
> sure the link does not exist when doing the build.
> =20
> This make sure the right header files are used for userboot builds=3D20
I suspect this will break cross-builds.
If the issue is in wrong machine/ symlink being installed, should
this be fixed instead ?
> =20
> diff --git a/sys/boot/userboot/ficl/Makefile =3D
> b/sys/boot/userboot/ficl/Makefile
> index 829ae1e..6249eb2 100644
> --- a/sys/boot/userboot/ficl/Makefile
> +++ b/sys/boot/userboot/ficl/Makefile
> @@ -61,6 +61,10 @@ softcore.c: ${SOFTWORDS} softcore.awk
> (cd ${.CURDIR}/../../ficl/softwords; cat ${SOFTWORDS} \
> | awk -f softcore.awk -v datestamp=3D3D"`LC_ALL=3D3DC date`") > =3D
> ${.TARGET}
> =3D20
> +beforedepend ${OBJS}: no-machine
> +
> +no-machine:
> + rm -f ${.CURDIR}/../../ficl/machine
> #.if ${MACHINE_CPUARCH} =3D3D=3D3D "amd64"
> #${SRCS:M*.c:R:S/$/.o/g}: machine
> #
> =20
> =20
> _______________________________________________
> freebsd-amd64@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-amd64
> To unsubscribe, send any mail to "freebsd-amd64-unsubscribe@freebsd.org"
--32mFWuI8C7a/mRQ2
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)
iEYEARECAAYFAk82HTsACgkQC3+MBN1Mb4hMZQCgz12tI+vwm8VxV0cFd5c5wlSH
3bcAoO8TXXbRTgTVkf8oMc415shGfqQW
=zk5U
-----END PGP SIGNATURE-----
--32mFWuI8C7a/mRQ2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120211074811.GR3283>